1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
phorge-phorge/webroot/rsrc/css
epriestley 1da54837ea Improve line breaking behavior in Firefox and Chrome under complex conditions
Summary: See <https://github.com/phacility/phabricator/pull/854>. In some situations, `line-break: anywhere` produces better behavior than `word-break: break-all`. It never appears to produce worse behavior.

Test Plan:
  - Break behavior changes if a line contains "<span />" elements caused by syntax highlighting. This CSS adjustment only appears to apply to text with internal "<span />" elements.
  - This specifically impacts certain internal breakpoints adjacent to punctuation, so the test case is highly specific. Generic test cases with latin word characters do not evidence any behavioral changes.
  - This change appears to have no impact on Safari, which uses the better behavior in all cases.
  - Before Patch: In Firefox and Chrome, this specific change breaks awkwardly. There is more room for text to fit on the broken line:

Firefox

{F7480567}

Chrome

{F7480568}

  - After Patch: Firefox and Chrome break the line better. Here's Firefox:

{F7480569}

  - Additional context:

Safari Behavior (Unchanged)

{F7480570}

Chrome with no highlighting (desirable behavior). Firefox does the same thing.

{F7480571}

Also tested other cases, which seem never-worse in any browser.

{F7480574}

Differential Revision: https://secure.phabricator.com/D21247
2020-05-13 11:54:42 -07:00
..
aphront When users submit "editing" inlines, warn them that their inlines will be saved 2020-05-04 13:13:15 -07:00
application Persist "Show Changeset" and improve path text selection 2020-05-08 06:59:10 -07:00
core Improve line breaking behavior in Firefox and Chrome under complex conditions 2020-05-13 11:54:42 -07:00
diviner Lots of little fixes for Dark Mode (Experimental) 2017-07-19 14:41:23 -07:00
font Show change information in file icons in the filetree 2020-04-22 08:38:29 -07:00
layout Entirely replace the old filetree UI with the "flank" UI 2020-04-22 08:32:02 -07:00
phui Improve line breaking behavior in Firefox and Chrome under complex conditions 2020-05-13 11:54:42 -07:00
syntax Generate syntax highlighting CSS from a reusable map 2016-05-05 02:50:48 -07:00
sprite-login.css Uh, update Phabricator login image 2017-08-11 13:37:26 -07:00
sprite-tokens.css More tokens 2016-07-03 18:32:40 -07:00