1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
phorge-phorge/src/applications/differential/constants
epriestley 1da691113a Normalize the definition of "closed" revision statuses
Summary:
Currently, "Closed" and "Abandoned" are treated as "closed". I want to add a flag which treats "Accepted" as "Closed", too, for Asana and other companies who use an Asana-like workflow.

The background here is that their workflow is a bit weird. They basically do audits, but have a lot of things which Diffusion doesn't do well right now. This one change makes Differential fit their workflow fairly well, even though it's an audit workflow.

To prepare for this, normalize the definition of "closed" better. We have a few callsites which explicitly check for "ABANDONED || CLOSED", and normalizing this is cleaner anyway.

Also delete the very old COMMITTED status, which has been obsolete for over a year.

Test Plan: Browsed around most/all of the affected interfaces.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D7653
2013-11-25 17:39:24 -08:00
..
DifferentialAction.php Show add reviewer typehead when user selects resign as a reviewer. 2013-07-10 11:05:53 -07:00
DifferentialChangeType.php PHT's for Differential. 2013-01-24 10:46:47 -08:00
DifferentialLintStatus.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialMailPhase.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialReviewerStatus.php Provide an "Add blocking reviewer..." Herald action 2013-10-06 17:09:24 -07:00
DifferentialRevisionControlSystem.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialRevisionStatus.php Normalize the definition of "closed" revision statuses 2013-11-25 17:39:24 -08:00
DifferentialUnitStatus.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialUnitTestResult.php Delete license headers from files 2012-11-05 11:16:51 -08:00