1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00
phorge-phorge/src
epriestley 1db281bcd1 Fix a possible count(null) in PHUIInfoView
Summary:
See <https://discourse.phabricator-community.org/t/php7-2-exception-count-parameter-must-be-an-array-or-an-object-that-implements-countable/1031>.

PHP7.2 raises a warning about `count(scalar)` (GREAT!) and we have one here if the caller doesn't `setErrors(...)`.

Test Plan: Sanity-checked usage of `$this->errors`.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18964
2018-01-29 15:16:41 -08:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Modularize rate/connection limits in Phabricator 2017-10-13 13:12:05 -07:00
applications Use the configured viewer more consistently in the Herald commit adapter 2018-01-29 15:00:26 -08:00
docs Document the new "only if this didn't match last time" Herald action setting 2018-01-26 11:06:43 -08:00
extensions Add src/extensions/ to Phabricator 2013-08-14 15:38:06 -07:00
infrastructure Add a bit of test coverage for bulky vs compact edge data representations 2018-01-29 11:34:57 -08:00
view Fix a possible count(null) in PHUIInfoView 2018-01-29 15:16:41 -08:00
__phutil_library_init__.php
__phutil_library_map__.php Add a bit of test coverage for bulky vs compact edge data representations 2018-01-29 11:34:57 -08:00