1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 11:22:40 +01:00
phorge-phorge/src/applications/herald
epriestley 204d1de683 Convert storage for Herald repetition policy to "text32"
Summary:
Depends on D18926. Ref T6203. Ref T13048. Herald rule repetition policies are stored as integers but treated as strings in most contexts.

After D18926, the integer stuff is almost totally hidden inside `HeraldRule` and getting rid of it completely isn't too tricky.

Do so now.

Test Plan:
  - Created "only the first time" and "every time" rules. Did a SELECT on their rows in the database.
  - Ran migrations, got a clean bill of health from `storage adjust`.
  - Did another SELECT on the rows, saw a faithful conversion to strings "every" and "first".
  - Edited and reviewed rules, swapping them between "every" and "first".

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13048, T6203

Differential Revision: https://secure.phabricator.com/D18927
2018-01-26 11:05:37 -08:00
..
action Allow Herald rules to add comments 2017-12-18 09:10:57 -08:00
adapter Remove "HeraldRepetitionPolicyConfig" and hide storage details inside HeraldRule 2018-01-26 11:03:29 -08:00
application Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
config Remove "HeraldRepetitionPolicyConfig" and hide storage details inside HeraldRule 2018-01-26 11:03:29 -08:00
contentsource Modularize content sources 2016-03-26 11:59:45 -07:00
controller Remove "HeraldRepetitionPolicyConfig" and hide storage details inside HeraldRule 2018-01-26 11:03:29 -08:00
editor Remove "HeraldRepetitionPolicyConfig" and hide storage details inside HeraldRule 2018-01-26 11:03:29 -08:00
engine Remove "HeraldRepetitionPolicyConfig" and hide storage details inside HeraldRule 2018-01-26 11:03:29 -08:00
engineextension Fully modularize DestructionEngine 2015-12-21 17:03:44 -08:00
field Don't run Herald build and mail rules when they don't make sense 2017-10-27 08:44:12 -07:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
group Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00
phid In Remarkup, render archived Herald rules with strikethrough for consistency 2016-12-08 12:37:54 -08:00
query Reduce application search engine results list for Dashboards 2017-02-22 12:42:43 -08:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
state Prepare TransactionEditor for silent transactions via bulk edit 2018-01-19 13:23:38 -08:00
storage Convert storage for Herald repetition policy to "text32" 2018-01-26 11:05:37 -08:00
typeahead Search builds based on who kicked them off 2016-07-31 20:54:44 +00:00
value Respect token limits for "Assign to" and custom datasource fields in Herald 2018-01-22 11:54:12 -08:00