1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-16 11:52:40 +01:00
phorge-phorge/src/applications/differential/view
epriestley 7276af6a81 Make yellow "draft" bubbles more generic
Summary:
Fixes T12095. Ref T6660. The old code for this was specific to Differential, using the `DifferentialDraft` table.

Instead, make the `EditEngine` / `VersionedDraft` code create and remove a `<objectPHID, authorPHID>` edge when a particular author creates drafts.

Some applications have drafts beyond `VersionedDrafts`, notably inline comments. Before writing "yes, draft" or "no, no draft", ask the object if it has any custom draft stuff we need to know about.

This should fix all the yellow bubble bugs I created in T11114 and allow us to bring the feature to Audit fairly easily.

Test Plan: Created and deleted comments and inlines, reloading the list view after each change. Couldn't find a way to break the list view anymore.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12095, T6660

Differential Revision: https://secure.phabricator.com/D17205
2017-01-13 09:02:19 -08:00
..
DifferentialChangesetDetailView.php Prettier file embeds 2016-11-27 14:57:06 -08:00
DifferentialChangesetFileTreeSideNavBuilder.php Convert all calls to 'IconFont' to just 'Icon' 2016-01-27 20:59:27 -08:00
DifferentialChangesetListView.php Fix mobile menu for files in Differential Changesets 2016-07-09 14:25:48 -07:00
DifferentialLocalCommitsView.php Merge "Table of Contents", "Local Commits", "Update History" and "Similar Revisions" 2016-06-30 18:50:52 -07:00
DifferentialReviewersView.php Rename "DifferentialReviewer" to "DifferentialReviewerProxy" 2016-12-13 14:35:35 -08:00
DifferentialRevisionListView.php Make yellow "draft" bubbles more generic 2017-01-13 09:02:19 -08:00
DifferentialRevisionUpdateHistoryView.php Show broken units in revision history 2016-09-02 10:29:29 -07:00
DifferentialTransactionView.php Make inline comment preview and submission mostly work on EditEngine 2016-12-31 10:10:29 -08:00