1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 06:42:42 +01:00
phorge-phorge/src
Andre Klapper c1d86da5b2 Initialize $cache_key variable in CelerityResourceController.php
Summary:
`$cache_key` is unconditionally called in `$cache->setKey($cache_key, $data)` but is only defined if the previous condition `if ($is_cacheable && $is_locally_cacheable && !$dev_mode)` was true.
Thus initialize the variable to avoid a theoretical exception. (No additional null check is needed as `$cache` gets defined in the same condition.)

Test Plan: Carefully read the code.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25642
2024-06-11 13:54:58 +02:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Correct PHPDoc or add default return for numerous methods 2024-05-18 21:54:51 +02:00
applications Initialize $cache_key variable in CelerityResourceController.php 2024-06-11 13:54:58 +02:00
docs docs/file_domain: Update cloudflare spelling and URLs 2024-05-07 13:01:39 +00:00
extensions
infrastructure Fix call to non-existing getTransactionCommentForSave() in PhabricatorInlineComment 2024-06-07 19:28:31 +02:00
view Curtain: add Hovercard support 2023-12-10 16:55:14 +01:00
__phutil_library_init__.php Rebrand: Rename library and update "version" logic 2022-08-25 01:26:21 -07:00
__phutil_library_map__.php Show login page if a search token requires a valid viewer 2024-06-04 16:10:50 +02:00