1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 07:12:41 +01:00
phorge-phorge/webroot/rsrc/js/application
Bob Trahan 22551d106d diffusion / differential - better handle case where no comment selected
Summary: Right now, if no comment is selected the JS executes and throws an exception. Instead, if nothing is selected just do nothing. Fixes T6107.

Test Plan: opened up a commit in diffusion with an inline comment. pressed 'r' and saw no exceptions and nothing happen. pressed 'n' to select the next inline comment and then 'r' and it worked. opened up a commit in diffusion without any inline comments. pressed 'r' and saw no exceptions and nothing happen. opened up a diff in differential with an inline comment. pressed 'r' and saw no exceptons and nothing happened. pressed 'n' to select the next inline comment and then 'r' and it worked.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6107

Differential Revision: https://secure.phabricator.com/D10843
2014-11-12 12:26:22 -08:00
..
aphlict Show a count (like "(3)") in the page title corresponding to unread notifications/messages 2014-09-10 10:17:49 -07:00
auth Add Persona auth provider 2013-10-14 14:34:57 -07:00
config Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
conpherence Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
countdown Fix countdown embeds and endless loops on resource loads in Javelin 2014-06-05 17:16:36 -07:00
dashboard Fix various spelling mistakes 2014-07-13 00:45:33 +10:00
differential diffusion / differential - better handle case where no comment selected 2014-11-12 12:26:22 -08:00
diffusion Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00
doorkeeper Various linter fixes. 2014-02-26 12:44:58 -08:00
files Various linter fixes. 2014-02-26 12:44:58 -08:00
herald Support placeholder text in Herald 2014-07-17 15:55:43 -07:00
maniphest Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00
owners Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00
passphrase Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
phame Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
pholio Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
phortune Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
policy Mostly modernize the policy control typeahead 2014-07-17 15:56:20 -07:00
ponder Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
projects Fix three issues with scrolling while dragging items (e.g., on workboards) 2014-09-09 14:20:27 -07:00
releeph Remove @group annotations 2014-07-10 08:12:48 +10:00
repository Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
search Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
slowvote Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
transactions Transactions - add "view raw" action 2014-08-07 15:21:32 -07:00
uiexample Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00