mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-04 12:42:43 +01:00
da40f80741
Summary: Ref T13217. This method is slightly tricky: - We can't safely return a string: return an array instead. - It no longer makes sense to accept glue. All callers use `', '` as glue anyway, so hard-code that. Then convert all callsites. Test Plan: Browsed around, saw fewer "unsafe" errors in error log. Reviewers: amckinley Reviewed By: amckinley Subscribers: yelirekim, PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13217 Differential Revision: https://secure.phabricator.com/D19784
117 lines
3.1 KiB
PHP
117 lines
3.1 KiB
PHP
<?php
|
|
|
|
final class DiffusionUpdateCoverageConduitAPIMethod
|
|
extends DiffusionConduitAPIMethod {
|
|
|
|
public function getAPIMethodName() {
|
|
return 'diffusion.updatecoverage';
|
|
}
|
|
|
|
public function getMethodStatus() {
|
|
return self::METHOD_STATUS_UNSTABLE;
|
|
}
|
|
|
|
public function getMethodDescription() {
|
|
return pht('Publish coverage information for a repository.');
|
|
}
|
|
|
|
protected function defineReturnType() {
|
|
return 'void';
|
|
}
|
|
|
|
protected function defineParamTypes() {
|
|
$modes = array(
|
|
'overwrite',
|
|
'update',
|
|
);
|
|
|
|
return array(
|
|
'repositoryPHID' => 'required phid',
|
|
'branch' => 'required string',
|
|
'commit' => 'required string',
|
|
'coverage' => 'required map<string, string>',
|
|
'mode' => 'optional '.$this->formatStringConstants($modes),
|
|
);
|
|
}
|
|
|
|
protected function execute(ConduitAPIRequest $request) {
|
|
$viewer = $request->getUser();
|
|
|
|
$repository_phid = $request->getValue('repositoryPHID');
|
|
$repository = id(new PhabricatorRepositoryQuery())
|
|
->setViewer($viewer)
|
|
->withPHIDs(array($repository_phid))
|
|
->executeOne();
|
|
|
|
if (!$repository) {
|
|
throw new Exception(
|
|
pht('No repository exists with PHID "%s".', $repository_phid));
|
|
}
|
|
|
|
$commit_name = $request->getValue('commit');
|
|
$commit = id(new DiffusionCommitQuery())
|
|
->setViewer($viewer)
|
|
->withRepository($repository)
|
|
->withIdentifiers(array($commit_name))
|
|
->executeOne();
|
|
if (!$commit) {
|
|
throw new Exception(
|
|
pht('No commit exists with identifier "%s".', $commit_name));
|
|
}
|
|
|
|
$branch = PhabricatorRepositoryBranch::loadOrCreateBranch(
|
|
$repository->getID(),
|
|
$request->getValue('branch'));
|
|
|
|
$coverage = $request->getValue('coverage');
|
|
$path_map = id(new DiffusionPathIDQuery(array_keys($coverage)))
|
|
->loadPathIDs();
|
|
|
|
$conn = $repository->establishConnection('w');
|
|
|
|
$sql = array();
|
|
foreach ($coverage as $path => $coverage_info) {
|
|
$sql[] = qsprintf(
|
|
$conn,
|
|
'(%d, %d, %d, %s)',
|
|
$branch->getID(),
|
|
$path_map[$path],
|
|
$commit->getID(),
|
|
$coverage_info);
|
|
}
|
|
|
|
$table_name = 'repository_coverage';
|
|
|
|
$conn->openTransaction();
|
|
$mode = $request->getValue('mode');
|
|
switch ($mode) {
|
|
case '':
|
|
case 'overwrite':
|
|
// sets the coverage for the whole branch, deleting all previous
|
|
// coverage information
|
|
queryfx(
|
|
$conn,
|
|
'DELETE FROM %T WHERE branchID = %d',
|
|
$table_name,
|
|
$branch->getID());
|
|
break;
|
|
case 'update':
|
|
// sets the coverage for the provided files on the specified commit
|
|
break;
|
|
default:
|
|
$conn->killTransaction();
|
|
throw new Exception(pht('Invalid mode "%s".', $mode));
|
|
}
|
|
|
|
foreach (PhabricatorLiskDAO::chunkSQL($sql) as $chunk) {
|
|
queryfx(
|
|
$conn,
|
|
'INSERT INTO %T (branchID, pathID, commitID, coverage) VALUES %LQ'.
|
|
' ON DUPLICATE KEY UPDATE coverage = VALUES(coverage)',
|
|
$table_name,
|
|
$chunk);
|
|
}
|
|
$conn->saveTransaction();
|
|
}
|
|
|
|
}
|