1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-21 17:58:47 +02:00
phorge-phorge/src/applications/differential
epriestley 269dd81f91 Allow users to re-accept or re-reject a revision if they have authority over package/project reviewers not yet in the target state
Summary:
To set this up:

  - alice accepts a revision.
  - Something adds a package or project she has authority over as a reviewer.
  - Because alice has already accepted, she can not re-accept, but she should be able to (in order to accept on behalf of the new project or package).

Test Plan:
  - Created a revision.
  - Accepted as user "dog".
  - Added "dog project".
  - Re-accepted.
  - Could not three-accept.
  - Removed "dog project.
  - Rejected.
  - Added "dog project".
  - Re-rejected.
  - Could not three-reject.

Reviewers: chad, eadler

Reviewed By: chad, eadler

Differential Revision: https://secure.phabricator.com/D17226
2017-01-18 13:16:01 -08:00
..
__tests__ phtize all the things 2015-05-22 21:16:39 +10:00
application Rename Differenital "EditPro" controller back to "Edit" 2016-12-16 13:17:12 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
command Define Differential email action in terms of EditEngine 2017-01-02 13:25:45 -08:00
conduit Remove some remnants of the old ways commit mesage fields worked from Differential 2017-01-13 15:29:07 -08:00
config Remove Differential "Title" custom field 2016-12-16 10:23:26 -08:00
constants Restore "Accept", "Reject" and "Resign" actions to Differential on EditEngine 2016-12-31 10:09:27 -08:00
controller Make yellow "draft" bubbles more generic 2017-01-13 09:02:19 -08:00
customfield Remove some remnants of the old ways commit mesage fields worked from Differential 2017-01-13 15:29:07 -08:00
doorkeeper Remove email prefixes from doorkeeper titles 2016-01-28 18:48:28 +00:00
edge Make the revision graph view more flexible 2016-07-01 10:40:49 -07:00
editor Get "Create Revision" out of Quick Create menu for now 2017-01-13 09:00:44 -08:00
engine Make yellow "draft" bubbles more generic 2017-01-13 09:02:19 -08:00
engineextension Convert Differential to new layout 2016-03-12 13:04:21 -08:00
exception Remove an unused class 2015-01-03 09:07:32 +11:00
field Remove some remnants of the old ways commit mesage fields worked from Differential 2017-01-13 15:29:07 -08:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
herald Fix a Herald issue where testing commits against rules with revision-related conditions would fail 2016-09-08 17:16:40 -07:00
landing Make "Land Revision" button state consistent, prevent non-accepted lands 2015-10-27 18:51:59 +00:00
lipsum Improve lipsum generation of projects 2015-12-24 09:06:56 -08:00
mail Improve HTML mail rendering of inline patches 2016-05-12 12:13:40 -07:00
management Remove most of the legacy hunk code 2016-12-13 14:34:36 -08:00
parser Always parse the first line of a commit message as a title 2017-01-01 09:56:15 -08:00
phid Render revision and audit state icons in Maniphest 2017-01-12 13:23:13 -08:00
query Show yellow "draft" bubble in Audit 2017-01-16 10:28:59 -08:00
relationships Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
render Bring up contrast on light green / red diffs 2017-01-04 15:18:24 -08:00
search Convert all "DocumentIndexers" into "FulltextEngines" 2015-12-21 17:25:23 -08:00
storage Make yellow "draft" bubbles more generic 2017-01-13 09:02:19 -08:00
typeahead Make Calendar query for indirect invites/RSVPs by default, like Differential 2016-11-15 12:47:01 -08:00
view Make yellow "draft" bubbles more generic 2017-01-13 09:02:19 -08:00
xaction Allow users to re-accept or re-reject a revision if they have authority over package/project reviewers not yet in the target state 2017-01-18 13:16:01 -08:00
DifferentialGetWorkingCopy.php Extend from Phobject 2015-06-15 18:02:27 +10:00