1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 17:52:43 +01:00
phorge-phorge/src/applications/harbormaster
William R. Otte 29436dfe37 Added 'method' field to the HTTP request build step.
Summary:
This revision adds a 'method' field to the HTTP request harbormaster build step.  This allows the user to specify GET, POST, DELETE, and PUT (limited by the underlying wrapper phabricator uses for HTTP requests).  I'm not sure how much sense PUT makes, but oh well.

Existing plans shouldn't break, as if this field is an empty string, we default to POST, which is the old behavior.

Fixes T4604

Test Plan: 1) Verified that the empty string does, in fact, issue a POST request.  Changed the method to be GET and observed that the problem described in T4604 is resolved.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: aran, epriestley

Maniphest Tasks: T4604

Differential Revision: https://secure.phabricator.com/D8520
2014-03-13 15:51:05 -07:00
..
application Allow entire buildables to restart/stop/resume 2014-01-06 14:12:15 -08:00
capability Harbormaster v(-2) 2013-10-22 15:01:06 -07:00
config Migrate "Run Command" to use Drydock hosts 2013-12-05 14:06:22 +11:00
controller Make Drydock blueprint create workflow somewhat more standard 2014-01-08 14:12:27 -08:00
editor Allow Harbormaster build plans to be disabled 2013-12-26 10:40:22 -08:00
engine Delete artifacts when restarting build 2014-01-28 20:17:36 -08:00
event Replace "Cancel Build" with "Stop", "Resume" and "Restart" 2014-01-06 12:32:20 -08:00
interface Add bin/harbormaster to make builds easier to debug 2013-12-26 10:40:52 -08:00
management Extend all "ManagementWorkflow" classes from a base class 2013-12-27 13:15:40 -08:00
phid Render build status on revisions and commits 2013-11-09 15:04:00 -08:00
query Replace "Cancel Build" with "Stop", "Resume" and "Restart" 2014-01-06 12:32:20 -08:00
remarkup Harbormaster v(-2) 2013-10-22 15:01:06 -07:00
step Added 'method' field to the HTTP request build step. 2014-03-13 15:51:05 -07:00
storage Truncate logSource in Harbormaster to the database column limit 2014-03-07 17:43:46 -08:00
view Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
worker Improve several exception behaviors for Harbormaster workers 2014-01-13 12:21:49 -08:00