mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-25 00:02:41 +01:00
29436dfe37
Summary: This revision adds a 'method' field to the HTTP request harbormaster build step. This allows the user to specify GET, POST, DELETE, and PUT (limited by the underlying wrapper phabricator uses for HTTP requests). I'm not sure how much sense PUT makes, but oh well. Existing plans shouldn't break, as if this field is an empty string, we default to POST, which is the old behavior. Fixes T4604 Test Plan: 1) Verified that the empty string does, in fact, issue a POST request. Changed the method to be GET and observed that the problem described in T4604 is resolved. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: aran, epriestley Maniphest Tasks: T4604 Differential Revision: https://secure.phabricator.com/D8520 |
||
|---|---|---|
| .. | ||
| BuildStepImplementation.php | ||
| CommandBuildStepImplementation.php | ||
| HarbormasterHTTPRequestBuildStepImplementation.php | ||
| HarbormasterThrowExceptionBuildStep.php | ||
| LeaseHostBuildStepImplementation.php | ||
| PublishFragmentBuildStepImplementation.php | ||
| SleepBuildStepImplementation.php | ||
| UploadArtifactBuildStepImplementation.php | ||
| VariableBuildStepImplementation.php | ||
| WaitForPreviousBuildStepImplementation.php | ||