mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-25 08:12:40 +01:00
996930da2a
Summary: Ref T2015. Several fixes: - `checkForCancellation()` no longer exists, and isn't relevant for resumable stops. Throw it away for now. - Fix an issue where a build could pass even if the final step failed. - `phlog()` exceptions so they show up in `bin/harbormaster` and the daemon logs. - Write an exception log if a step fails. - Add a "throw an exception" step to debug this stuff more easily. Test Plan: - Grepped for `checkForCancellation()`. - Ran a failing build where the final step caused the failure. - Observed `phlog()` in `bin/harbormaster` output. - Observed log in web UI: {F101168} Reviewers: btrahan, hach-que Reviewed By: btrahan CC: aran Maniphest Tasks: T2015 Differential Revision: https://secure.phabricator.com/D7935
108 lines
2.9 KiB
PHP
108 lines
2.9 KiB
PHP
<?php
|
|
|
|
final class CommandBuildStepImplementation
|
|
extends VariableBuildStepImplementation {
|
|
|
|
public function getName() {
|
|
return pht('Run Command');
|
|
}
|
|
|
|
public function getGenericDescription() {
|
|
return pht('Run a command on Drydock host.');
|
|
}
|
|
|
|
public function getDescription() {
|
|
$settings = $this->getSettings();
|
|
|
|
return pht(
|
|
'Run \'%s\' on \'%s\'.',
|
|
$settings['command'],
|
|
$settings['hostartifact']);
|
|
}
|
|
|
|
public function execute(
|
|
HarbormasterBuild $build,
|
|
HarbormasterBuildTarget $build_target) {
|
|
|
|
$settings = $this->getSettings();
|
|
$variables = $build_target->getVariables();
|
|
|
|
$command = $this->mergeVariables(
|
|
'vcsprintf',
|
|
$settings['command'],
|
|
$variables);
|
|
|
|
$artifact = $build->loadArtifact($settings['hostartifact']);
|
|
|
|
$lease = $artifact->loadDrydockLease();
|
|
|
|
$interface = $lease->getInterface('command');
|
|
|
|
$future = $interface->getExecFuture('%C', $command);
|
|
|
|
$log_stdout = $build->createLog($build_target, "remote", "stdout");
|
|
$log_stderr = $build->createLog($build_target, "remote", "stderr");
|
|
|
|
$start_stdout = $log_stdout->start();
|
|
$start_stderr = $log_stderr->start();
|
|
|
|
// Read the next amount of available output every second.
|
|
while (!$future->isReady()) {
|
|
list($stdout, $stderr) = $future->read();
|
|
$log_stdout->append($stdout);
|
|
$log_stderr->append($stderr);
|
|
$future->discardBuffers();
|
|
|
|
// Wait one second before querying for more data.
|
|
sleep(1);
|
|
}
|
|
|
|
// Get the return value so we can log that as well.
|
|
list($err) = $future->resolve();
|
|
|
|
// Retrieve the last few bits of information.
|
|
list($stdout, $stderr) = $future->read();
|
|
$log_stdout->append($stdout);
|
|
$log_stderr->append($stderr);
|
|
$future->discardBuffers();
|
|
|
|
$log_stdout->finalize($start_stdout);
|
|
$log_stderr->finalize($start_stderr);
|
|
|
|
if ($err) {
|
|
throw new Exception(pht('Command failed with error %d.', $err));
|
|
}
|
|
}
|
|
|
|
public function validateSettings() {
|
|
$settings = $this->getSettings();
|
|
|
|
if ($settings['command'] === null || !is_string($settings['command'])) {
|
|
return false;
|
|
}
|
|
if ($settings['hostartifact'] === null ||
|
|
!is_string($settings['hostartifact'])) {
|
|
return false;
|
|
}
|
|
|
|
// TODO: Check if the host artifact is provided by previous build steps.
|
|
|
|
return true;
|
|
}
|
|
|
|
public function getSettingDefinitions() {
|
|
return array(
|
|
'command' => array(
|
|
'name' => 'Command',
|
|
'description' => 'The command to execute on the remote machine.',
|
|
'type' => BuildStepImplementation::SETTING_TYPE_STRING),
|
|
'hostartifact' => array(
|
|
'name' => 'Host Artifact',
|
|
'description' =>
|
|
'The host artifact that determines what machine the command '.
|
|
'will run on.',
|
|
'type' => BuildStepImplementation::SETTING_TYPE_ARTIFACT,
|
|
'artifact_type' => HarbormasterBuildArtifact::TYPE_HOST));
|
|
}
|
|
|
|
}
|