1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 07:42:40 +01:00
phorge-phorge/src/applications/drydock
epriestley f5580c7a08 Make buildWhereClause() a method of AphrontCursorPagedPolicyAwareQuery
Summary:
Ref T4100. Ref T5595.

To support a unified "Projects:" query across all applications, a future diff is going to add a set of "Edge Logic" capabilities to `PolicyAwareQuery` which write the required SELECT, JOIN, WHERE, HAVING and GROUP clauses for you.

With the addition of "Edge Logic", we'll have three systems which may need to build components of query claues: ordering/paging, customfields/applicationsearch, and edge logic.

For most clauses, queries don't currently call into the parent explicitly to get default components. I want to move more query construction logic up the class tree so it can be shared.

For most methods, this isn't a problem, but many subclasses define a `buildWhereClause()`. Make all such definitions protected and consistent.

This causes no behavioral changes.

Test Plan: Ran `arc unit --everything`, which does a pretty through job of verifying this statically.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: yelirekim, hach-que, epriestley

Maniphest Tasks: T4100, T5595

Differential Revision: https://secure.phabricator.com/D12453
2015-04-20 10:06:09 -07:00
..
application Allow applications to have multiple "help" menu items 2015-04-01 11:51:48 -07:00
blueprint Policy - convert Drydock query for repository to policy-based query 2015-02-03 12:28:11 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
constants Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
controller Increase visibility of PhabricatorController::buildApplicationMenu methods 2015-01-16 07:41:26 +11:00
customfield Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
editor Modularize mail tags 2014-08-12 12:28:41 -07:00
interface Check to make sure credential is not null in SSH command interface 2015-01-28 23:40:34 +00:00
management Fix visibility of PhutilArgumentWorkflow::didConstruct methods 2015-01-16 07:42:07 +11:00
phid Rename PHIDType classes 2014-07-24 08:05:46 +10:00
query Make buildWhereClause() a method of AphrontCursorPagedPolicyAwareQuery 2015-04-20 10:06:09 -07:00
storage Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
util Restructure Drydock so that blueprints are instances in the DB 2013-12-03 11:09:07 +11:00
view Move Drydock object list rendering to SearchEngine 2014-05-13 12:14:33 -07:00
worker Increase Drydock worker time to 24 hours 2014-09-25 09:46:47 +10:00