mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-28 01:32:42 +01:00
2bdb5404c7
Summary: Ref T7707. Ref T4406. Ref T2479. This implements the profile-style (fixed width and height) transforms in a modern way. - Added a "regnerate" feature to the support UI to make testing easier and surface errors. - Laboriously check errors from everything. - Fix the profile thumbnailing so it crops properly instead of leaving margins. - Also defuses the "gigantic white PNG" attack. This doesn't handle the imagemagick case (for animated GIFs) yet. Test Plan: - Uploaded a variety of wide/narrow/small/large files and converted them into sensible profile pictures. - Tried to thumbnail some text files. - Set the pixel-size and file-size limits artificially small and hit them. - Used "regenerate" a bunch while testing the rest of this stuff. - Verified that non-regenerate flows still produce a default/placeholder image. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4406, T2479, T7707 Differential Revision: https://secure.phabricator.com/D12811 |
||
|---|---|---|
| .. | ||
| action | ||
| application | ||
| applicationpanel | ||
| capability | ||
| conduit | ||
| config | ||
| controller | ||
| edge | ||
| editor | ||
| engine | ||
| exception | ||
| garbagecollector | ||
| lipsum | ||
| management | ||
| markup | ||
| phid | ||
| query | ||
| storage | ||
| transform | ||
| view | ||
| PhabricatorImageTransformer.php | ||