1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-07 12:28:28 +01:00
phorge-phorge/src/applications/repository/storage
bob acfb44d667 Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page
Summary:
With PHP 8.1+ it is not possible to view a commit if the author field is not properly defined
Indeed, if the commit author is not properly defined, strlen(null) is called, causing a deprecation warning, elevated to exception.
Using strlen() to check string validity is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Fix T15628

Test Plan:
- Push a new commit on a subversion repository (since T15629 is not yet addressed)
- Visualize the commit
- You should not get a RuntimeException

Reviewers: O1 Blessed Committers, Sten, valerio.bozzolan

Reviewed By: O1 Blessed Committers, Sten, valerio.bozzolan

Subscribers: Sten, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15628

Differential Revision: https://we.phorge.it/D25422
2023-11-22 16:55:32 +01:00
..
__tests__ Update templates used with mercurial to remove '--debug' 2021-07-09 12:35:20 -04:00
PhabricatorRepository.php Fix PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo creation 2023-11-04 19:35:01 +01:00
PhabricatorRepositoryAuditRequest.php Modernize and clean up "PhabricatorAuditStatusConstants" 2021-03-10 09:21:55 -08:00
PhabricatorRepositoryBranch.php Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
PhabricatorRepositoryCommit.php Fix a PHP 8.1 deprecated use of strlen with a NULL argument 2023-11-22 16:54:29 +01:00
PhabricatorRepositoryCommitData.php Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page 2023-11-22 16:55:32 +01:00
PhabricatorRepositoryCommitHint.php Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
PhabricatorRepositoryDAO.php Delete license headers from files 2012-11-05 11:16:51 -08:00
PhabricatorRepositoryGitLFSRef.php Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
PhabricatorRepositoryIdentity.php Add Diffusion policy capability "Can Edit and View Identities" 2023-11-11 13:27:11 +01:00
PhabricatorRepositoryIdentityTransaction.php Add controllers/search/edit engine functionality to RepositoryIdentity 2018-05-31 07:03:25 -07:00
PhabricatorRepositoryMirror.php Cut mirroring over to new URIs 2016-05-04 16:16:16 -07:00
PhabricatorRepositoryOldRef.php Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
PhabricatorRepositoryPullEvent.php Make minor correctness and display improvements to pull logs 2018-01-23 14:13:18 -08:00
PhabricatorRepositoryPushEvent.php Allow maintenance scripts to write synthetic events to the push log that act as repository updates 2021-06-01 08:29:54 -07:00
PhabricatorRepositoryPushLog.php Allow maintenance scripts to write synthetic events to the push log that act as repository updates 2021-06-01 08:29:54 -07:00
PhabricatorRepositoryRefCursor.php Separate "shouldPublishRef()" from "isPermanentRef()" and set "IMPORTED_PERMANENT" more narrowly 2021-01-22 19:51:38 -08:00
PhabricatorRepositoryRefPosition.php Add a RefPosition table to hold branch/tag positions once the RefCursor table is split 2017-09-15 10:19:17 -07:00
PhabricatorRepositorySchemaSpec.php Migrate the "badcommit" table to use the less-hacky "hint" mechanism 2016-08-24 09:32:59 -07:00
PhabricatorRepositoryStatusMessage.php When repositories hit pull errors, stop updating them as frequently 2016-09-19 17:29:56 -07:00
PhabricatorRepositorySymbol.php Framework for external symbol search 2015-05-31 07:37:06 -07:00
PhabricatorRepositorySyncEvent.php Add a basic web UI for intracluster sync logs 2018-11-10 04:58:36 -08:00
PhabricatorRepositoryTransaction.php Make the default behavior of getApplicationTransactionCommentObject() "return null" instead of "throw" 2019-02-07 14:56:38 -08:00
PhabricatorRepositoryURI.php Fix PHP 8.1 "strlen(null)" exception setting a Diffusion repo URI when diffusion.ssh-host is null 2023-06-08 10:30:08 +02:00
PhabricatorRepositoryURIIndex.php Unify intracluster sync and Drydock working copy construction timeouts as a repository "copy time limit" 2018-11-16 13:08:12 -08:00
PhabricatorRepositoryURITransaction.php Correct Transaction text when changing Diffusion URI I/O type 2023-09-28 09:19:55 +02:00
PhabricatorRepositoryWorkingCopyVersion.php Parameterize the repository read and write locks 2018-09-24 15:14:28 -07:00