1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-11 09:22:40 +01:00
phorge-phorge/src/applications
epriestley 302da70e72 Synchronize review request state to Asana
Summary:
Ref T2852. Depends on D6302. This now creates, destroys, and synchronizes subtasks.

  - After finishing the parent task stuff, we pull a list of all known subtasks.
  - We load all those subtasks.
  - If we fail to load any, we delete their objects and edges on the Phabricator side.
  - Of the remaining subtasks, we find subtasks for users who aren't related to the object any more and delete them in Asana and locally (for example, if alincoln is removed as a reviewer, we delete his subtask).
  - For all the related users, we either synchronize their existing task or create a new one for them.
  - Then we write edges for any new tasks we added.

This doesn't handle a few weird edge cases in any specific way:

  - If a subtask is moved under a different parent, we ignore it.
  - If a new subtask is created that we don't know about, we ignore it.
  - If a subtask we know about is deleted, we just respawn it. This is consistent with "DON'T EDIT THESE". You can force sync to stop by deleting the parent.

Addititionally:

  - Make the "don't edit" warning more compelling and visceral.

Test Plan:
  - Kind of ran it a bit.
  - There are like 3,000 edge cases here so this is hard to test exhaustively.
  - Forced a few of the edge cases to happen.
  - Nothing seems immediately broken in an obvious way?

{F47551}

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2852

Differential Revision: https://secure.phabricator.com/D6303
2013-06-25 16:33:46 -07:00
..
arcanist/conduit Move Conduit methods inside applications 2012-12-21 12:21:59 -08:00
audit Tweak audit status colors. 2013-06-11 20:53:55 -07:00
auth Fix OAuth token refresh return value 2013-06-25 16:31:01 -07:00
base Provide contextual help on auth provider configuration 2013-06-20 11:18:48 -07:00
cache Provide 'bin/cache', for managing caches 2013-05-20 10:16:35 -07:00
calendar Conpherence calendar updates 2013-05-29 14:35:34 -07:00
chatlog Consolidate some datetime code and add unit tests 2013-06-03 12:58:11 -07:00
conduit Store hash of session key 2013-05-30 17:30:06 -07:00
config Make ignored setup issues grey 2013-06-25 10:17:46 -07:00
conpherence Conpherence - fix no messages button 2013-06-14 17:00:09 -07:00
countdown PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00
daemon reduce noise on daemon console 2013-03-08 13:08:11 -08:00
differential Simplify selection of inline comments from RevisionView 2013-06-24 11:01:51 -07:00
diffusion Add remarkup support for Asana URIs 2013-06-24 15:55:08 -07:00
directory/controller Remove all the container node stuff from AphrontTagView 2013-06-05 16:21:55 -07:00
diviner Fix search and core icons in top nav 2013-06-09 09:11:32 -07:00
doorkeeper Synchronize review request state to Asana 2013-06-25 16:33:46 -07:00
draft/storage Add draft support to ApplicationTransactions 2012-12-21 05:57:14 -08:00
drydock Add PhabricatorWorker->log() 2013-06-25 16:31:37 -07:00
fact Convert AphrontTableView to safe HTML 2013-02-09 15:11:38 -08:00
feed Initial Asana sync for Differential 2013-06-25 16:33:16 -07:00
files Implement PhutilRequest parser #2 2013-06-24 08:22:26 -07:00
flag Minor, correct more application class name spellings. 2013-05-15 17:01:34 -07:00
harbormaster Add HarbormasterRunnerWorker, for running CI tests 2012-12-17 13:43:26 -08:00
help/controller Some help pht 2013-05-21 15:29:21 -07:00
herald PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00
lipsum Files Generating 2013-05-06 10:30:38 -07:00
macro Default application search to the topmost filter 2013-06-05 18:58:50 -07:00
mailinglists PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00
maniphest Valdiate custom field keys 2013-06-24 09:28:36 -07:00
meta Fix white + icon hover / apps create 2013-06-11 19:10:12 -07:00
metamta Expand the "PhabricatorExternalAccount" table for new registration 2013-06-14 06:55:18 -07:00
notification Fix weird "0" notification numbers 2013-05-21 15:44:44 -07:00
oauthserver Fix an OAuthServer issue where an attacker could make a link function over HTTP when it should be HTTPS-only 2013-02-19 16:09:36 -08:00
owners PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00
paste Default application search to the topmost filter 2013-06-05 18:58:50 -07:00
people Provide contextual help on auth provider configuration 2013-06-20 11:18:48 -07:00
phame Fix issue where https is not honoured when loading disqus api 2013-06-25 16:32:51 -07:00
phid Add remarkup support for Asana URIs 2013-06-24 15:55:08 -07:00
phlux PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00
pholio Make ApplicationTransactions preview -> submit flow less janky 2013-06-24 15:41:59 -07:00
phortune PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00
phpast Uninstall Conduit calls when uninstalling applications 2013-03-13 07:09:05 -07:00
phrequent Updates to phrequent's landing page 2013-04-29 12:01:02 -07:00
phriction PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00
policy Improve policy description strings in ApplicationTransactions 2013-05-26 09:51:14 -07:00
ponder PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00
project PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00
releeph Put all DifferentialComment loading behind DifferentialCommentQuery 2013-06-21 12:51:18 -07:00
remarkup/conduit Convert Remarkup to safe HTML 2013-02-13 12:34:49 -08:00
repository Fix the type of some values passed to MySQL 2013-06-13 18:01:40 -07:00
search Default application search to the topmost filter 2013-06-05 18:58:50 -07:00
settings Add a "refresh" action for external accounts 2013-06-24 15:58:27 -07:00
slowvote PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00
subscriptions Remove subscribe icons 2013-06-06 15:06:08 -07:00
system Add a user-accessible hook for dumping debug code into an install 2013-03-04 13:45:51 -08:00
tokens Token - fix fatal for installs with no tokens yet given 2013-05-23 11:58:23 -07:00
transactions Make ApplicationTransactions preview -> submit flow less janky 2013-06-24 15:41:59 -07:00
typeahead unbreak typeaheads for /owners/new 2013-06-20 08:49:20 -07:00
uiexample Implement color variables in CSS. 2013-06-19 20:25:41 -07:00
xhprof Fix XHProf index page 2013-04-02 09:52:52 -07:00