1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-22 10:18:48 +02:00
phorge-phorge/src/applications/differential
epriestley c86dfd84d9 Wrap basic diff/revision association in a transaction
Summary:
This doesn't cover every case exhaustively (see comments) but should cover like
98% of the practical cases.

This makes one workflow modification: willWriteRevision() was previously
guaranteed to have a revisionID / revisionPHID and no longer is. I verified that
no field implementations depend on this behavior. Fields which depend on IDs
should be using didWriteRevision() instead.

Test Plan: Inserted a "throw" into the middle of the transactions and created
revisions; they didn't orphan. Created revisions normally, they worked
correctly.

Reviewers: btrahan, nh

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T605

Differential Revision: https://secure.phabricator.com/D1541
2012-02-02 16:03:44 -08:00
..
constants Deploy new ArcanistManyWordsAboutDifferentialConstants class from D1328 into 2012-01-10 11:49:20 -08:00
controller Provide better UX when trying to view binary file from differential 2012-01-31 17:24:21 -08:00
data/revisionlist Deploy new ArcanistManyWordsAboutDifferentialConstants class from D1328 into 2012-01-10 11:49:20 -08:00
editor Wrap basic diff/revision association in a transaction 2012-02-02 16:03:44 -08:00
exception Improve behavior when user submits a no-op action in Differential 2012-01-15 03:44:09 -08:00
field Remove the "arc export" field from Differential revisions by default 2012-01-27 13:02:11 -08:00
mail Don't output empty summary in e-mails 2012-01-31 10:41:31 -08:00
parser/changeset Minor, add "cov" class to inline comment <td /> so new files with lint in them do not go crazy. 2012-01-31 18:30:22 -08:00
query/revision Allow differential.query to find accepted and committed revisions; fix a fatal 2012-01-25 14:50:34 -08:00
replyhandler Don't add author and reviewers to CCs 2012-01-14 11:10:40 -08:00
storage Change fileName to filename 2012-01-17 10:50:14 -08:00
tasks Enable updating task->revision assoc 2011-04-26 19:14:47 -07:00
view Fix issue where all rows in "Revision Update History" render the same base 2012-01-31 12:07:41 -08:00