mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-14 10:52:41 +01:00
77eae81e1a
Summary: Ref T7094. We should do a policy query on the files IMO because there exists a scenario where the file gets locked down directly. This requires being a bit more disciplined about setting user, which in turn requires deciding whether or not to show edit / reply links as a separate piece of logic, not conditional on user presence. This is not the best code but I don't think it gets worse with this and is just some other nuance in any larger cleanup we take on someday. Test Plan: looked at a revision and noted inline comments rendered correctly with reply / edit actions. looked at a diff standalone and noted no reply / edit actions as expected. looked at a "details" link on a transaction and it rendered correctly. looked at a diff in phriction of page edits and it looked good. grepped around and verified the remaining callsite in diffusion already has the setUser call. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7094 Differential Revision: https://secure.phabricator.com/D11579 |
||
|---|---|---|
| .. | ||
| DifferentialChangesetHTMLRenderer.php | ||
| DifferentialChangesetOneUpRenderer.php | ||
| DifferentialChangesetOneUpTestRenderer.php | ||
| DifferentialChangesetRenderer.php | ||
| DifferentialChangesetTestRenderer.php | ||
| DifferentialChangesetTwoUpRenderer.php | ||
| DifferentialChangesetTwoUpTestRenderer.php | ||
| DifferentialRawDiffRenderer.php | ||