1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/differential
Bob Trahan 5a9df1a225 Policy - filter app engines where the user can't see the application from panel editing
Summary: Fixes T7118. This does the basic "filter the list" thing, though it ends up being a little manual since I guess this hasn't come up before? There is also potential weird behavior if the user was using an app and lost access to it - they will have nothing selected on edit - but I think this is actually correct behavior in this circumstance.

Test Plan:
used a user who couldn't get access to the "quick create" apps and noted that the dropdown list on dashboard panel create was missing the expected engines

ran `arc unit --everything` to verify abstract method implemented everywhere

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7118

Differential Revision: https://secure.phabricator.com/D11687
2015-02-04 15:47:48 -08:00
..
__tests__ Policy - fix up DifferentialChangesetParser 2015-01-30 11:17:34 -08:00
application Remove getIconName from all applications 2015-01-30 12:11:21 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit Differential - add ability to setup "create" addresses for revisions 2015-01-30 10:31:39 -08:00
config Use icons with Config Options page 2015-02-02 10:17:25 -08:00
constants Differential - label unit / lint results from the commit diff as not applicable 2014-09-16 12:11:54 -07:00
controller Revert "Have DifferentialRevisionList return an ObjectBox if header is set" 2015-02-03 12:16:42 -08:00
customfield Fix visibility for DifferentialManiphestTasksField::readValueFromRevision 2015-01-14 07:04:36 +11:00
doorkeeper Partially modernize Doorkeeper/Asana bridge 2014-10-01 07:09:34 -07:00
edge Don't write inverse edges for DifferentialRevisionHasReviewerEdgeType 2015-01-04 10:07:56 +11:00
editor Don't create mentions for dependent diffs 2015-01-23 07:12:05 +11:00
event Revamp Profile with new IconNav 2015-02-02 12:13:48 -08:00
exception Remove an unused class 2015-01-03 09:07:32 +11:00
garbagecollector Complete modularization of the GC daemon 2014-01-15 10:02:31 -08:00
landing Explicitly declare method/property visibility 2015-01-12 08:18:13 +11:00
lipsum Remove an unused variable 2015-01-03 10:31:46 +11:00
mail Differential - add ability to setup "create" addresses for revisions 2015-01-30 10:31:39 -08:00
management Rename DifferentialHunk subclasses for consistency 2015-01-23 07:17:04 +11:00
parser Policy - fix up DifferentialChangesetParser 2015-01-30 11:17:34 -08:00
phid Rename PHIDType classes 2014-07-24 08:05:46 +10:00
query Policy - filter app engines where the user can't see the application from panel editing 2015-02-04 15:47:48 -08:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
render Policy - fix up DifferentialChangesetParser 2015-01-30 11:17:34 -08:00
search Rename PHIDType classes 2014-07-24 08:05:46 +10:00
storage Probably fix excessive "(authored by X)" attributions 2015-02-02 14:59:32 -08:00
view Revert "Have DifferentialRevisionList return an ObjectBox if header is set" 2015-02-03 12:16:42 -08:00
DifferentialGetWorkingCopy.php Applied various linter fixes. 2014-06-09 16:04:12 -07:00