1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
phorge-phorge/src/applications/differential
epriestley 35750b9c61 Make some Differential comment actions (like "Accept" and "Reject") conflict with one another
Summary:
Ref T11114. When a user selects "Accept", and then selects "Reject", remove the "Accept". It does not make sense to both accept and reject a revision.

For now, every one of the "actions" conflicts: accept, reject, resign, claim, close, commandeer, etc, etc. I couldn't come up with any combinations that it seems like users are reasonably likely to want to try, and we haven't received combo-action requests in the past that I can recall.

Test Plan:
  - Selected "Accept", then selected "Reject". One replaced the other.
  - Selected "Accept", then selected "Change Subscribers". Both co-existed happily.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17132
2017-01-02 13:25:12 -08:00
..
__tests__ phtize all the things 2015-05-22 21:16:39 +10:00
application Rename Differenital "EditPro" controller back to "Edit" 2016-12-16 13:17:12 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
command Generate mail command documentation from active commands 2015-04-01 11:51:47 -07:00
conduit Remove "Revision ID" custom field 2016-12-16 10:22:28 -08:00
config Remove Differential "Title" custom field 2016-12-16 10:23:26 -08:00
constants Restore "Accept", "Reject" and "Resign" actions to Differential on EditEngine 2016-12-31 10:09:27 -08:00
controller Use extended policies in Differential diffs 2017-01-01 09:56:30 -08:00
customfield Simplify "Blame Revision" field in Differential 2016-12-16 12:03:46 -08:00
doorkeeper Remove email prefixes from doorkeeper titles 2016-01-28 18:48:28 +00:00
edge Make the revision graph view more flexible 2016-07-01 10:40:49 -07:00
editor Make marking comments as "Done" work cleanly on EditEngine 2016-12-31 10:12:01 -08:00
engine Return Diffusion diffs through Files, not directly over Conduit 2016-08-27 09:11:03 -07:00
engineextension Convert Differential to new layout 2016-03-12 13:04:21 -08:00
exception Remove an unused class 2015-01-03 09:07:32 +11:00
field Be more lenient when accepting "Differential Revision" in the presence of custom ad-hoc commit message fields 2017-01-01 09:56:02 -08:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
herald Fix a Herald issue where testing commits against rules with revision-related conditions would fail 2016-09-08 17:16:40 -07:00
landing Make "Land Revision" button state consistent, prevent non-accepted lands 2015-10-27 18:51:59 +00:00
lipsum Improve lipsum generation of projects 2015-12-24 09:06:56 -08:00
mail Improve HTML mail rendering of inline patches 2016-05-12 12:13:40 -07:00
management Remove most of the legacy hunk code 2016-12-13 14:34:36 -08:00
parser Always parse the first line of a commit message as a title 2017-01-01 09:56:15 -08:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
query Rename "DifferentialReviewer" to "DifferentialReviewerProxy" 2016-12-13 14:35:35 -08:00
relationships Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
render Render more info for binary files in Differential 2016-06-06 19:58:39 +00:00
search Convert all "DocumentIndexers" into "FulltextEngines" 2015-12-21 17:25:23 -08:00
storage Use extended policies in Differential diffs 2017-01-01 09:56:30 -08:00
typeahead Make Calendar query for indirect invites/RSVPs by default, like Differential 2016-11-15 12:47:01 -08:00
view Make inline comment preview and submission mostly work on EditEngine 2016-12-31 10:10:29 -08:00
xaction Make some Differential comment actions (like "Accept" and "Reject") conflict with one another 2017-01-02 13:25:12 -08:00
DifferentialGetWorkingCopy.php Extend from Phobject 2015-06-15 18:02:27 +10:00