1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 05:50:55 +01:00
phorge-phorge/webroot/rsrc/css
epriestley 37ffb71c4d In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior
Summary:
Ref T2495. See PHI1814. Currently, Phabricator replaces tabs with spaces when rendering diffs.

This may or may not be the best behavior in the long term, but it gives us more control over expansion of tabs than using tab literals.

However, one downside is that you can use your mouse cursor to select "half a tab", and can't use your mouse cursor to distinguish between tabs and spaces. Although you probably shouldn't be doing this, this behavior is less accurate/correct than selecting the entire block as a single unit.

A specific correctness issue with this behavior is that the entire block is copied to the clipboard as a tab literal if you select any of it, so two different visual selection ranges can produce the same clipboard content.

This particular behavior can be improved with "user-select: all", to instruct browsers to select the entire element as a single logical element. Now, selecting part of the tab selects the whole thing, as though it were really a tab literal.

(Some future change might abandon this approach and opt to use real tab literals with "tab-size" CSS, but we lose some ability to control alignment behavior if we do that and it doesn't have any obvious advantages over this approach other than cursor selection behavior.)

Test Plan:
  - In Safari and Firefox, dragged text to select a whitespace-expanded tab literal. Saw browsers select the whole sequence as though it were a single tab.
  - In Chorme, this also mostly works, but there's some glitchiness and flickering. I think this is still a net improvement, it's just not as smooth as Safari and Firefox.

Maniphest Tasks: T2495

Differential Revision: https://secure.phabricator.com/D21419
2020-07-17 15:10:06 -07:00
..
aphront When users submit "editing" inlines, warn them that their inlines will be saved 2020-05-04 13:13:15 -07:00
application Render inline comment suggestions as real diffs 2020-05-20 14:27:40 -07:00
core In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior 2020-07-17 15:10:06 -07:00
diviner Lots of little fixes for Dark Mode (Experimental) 2017-07-19 14:41:23 -07:00
font Show change information in file icons in the filetree 2020-04-22 08:38:29 -07:00
layout Entirely replace the old filetree UI with the "flank" UI 2020-04-22 08:32:02 -07:00
phui Improve line breaking behavior in Firefox and Chrome under complex conditions 2020-05-13 11:54:42 -07:00
syntax Generate syntax highlighting CSS from a reusable map 2016-05-05 02:50:48 -07:00
sprite-login.css Uh, update Phabricator login image 2017-08-11 13:37:26 -07:00
sprite-tokens.css More tokens 2016-07-03 18:32:40 -07:00