1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-30 02:32:42 +01:00
phorge-phorge/src/applications/people
Andre Klapper c86364c2aa Fix PHP 8.1 "strlen(null)" exceptions which block rendering user page after creation with Welcome Email enabled
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15374

Test Plan: Applied these two changes, performed the user creation steps again, and afterwards the user page at `/p/user5/` finally rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15374

Differential Revision: https://we.phorge.it/D25208
2023-05-10 10:28:33 +02:00
..
application Add a test to verify that all routing maps are plausibly valid, and remove some dead routes 2020-02-14 18:06:24 -08:00
cache Reduce the cost of generating default user profile images 2018-03-01 16:53:17 -08:00
capability Add a "Can Disable Users" capability to the "People" application 2018-08-27 08:01:27 -07:00
conduit Deprecate "user.enable" and "user.disable" API methods, redefine them in terms of "user.edit" 2018-08-27 08:00:48 -07:00
config Move "wild" config types to new code 2017-06-27 12:34:56 -07:00
controller Remove product literal strings in "pht()", part 22 2022-04-25 16:46:26 -07:00
customfield Hide "Availability" and "Calendar" on user profiles for disabled users 2019-03-28 17:24:35 -07:00
editor Update repository identities after all mutations to users and email addresses 2019-11-19 09:41:59 -08:00
engine Add Revisions to User Profiles 2017-05-21 09:24:37 -07:00
engineextension Render user hovercards with context information about their ability to see the context object 2021-02-13 13:37:37 -08:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
guidance Add a bunch of Phacility-specific code to the upstream, thinly veiled as generic code 2016-11-15 09:11:22 -08:00
icon Add additional icons for User Profiles 2016-01-31 20:09:06 +00:00
lipsum Make bin/lipsum generate hanldle generator keys and arguments more clearly 2017-02-27 09:09:28 -08:00
mail Fix PHP 8.1 "strlen(null)" exceptions which block rendering user page after creation with Welcome Email enabled 2023-05-10 10:28:33 +02:00
management Provide new tool "bin/user approve" to approve an account. 2021-03-03 04:35:50 +00:00
markup Render user hovercards with context information about their ability to see the context object 2021-02-13 13:37:37 -08:00
menuitem Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page of a user 2023-05-01 22:03:41 +02:00
phid Add an "ExternalAccountIdentifier" table 2020-02-22 17:44:13 -08:00
policyrule Move some files around 2015-11-17 06:26:13 +11:00
query People: add a permalink to list Administrators 2023-04-08 09:47:12 +02:00
search Reduce the amount of boilerplate that implementing FerretInterface requires 2017-09-07 13:23:31 -07:00
searchfield Add basic typechecking support to Conduit 2015-12-14 04:21:39 -08:00
storage Rename default SSH key name from Phabricator to Phorge 2023-04-27 09:29:05 +02:00
typeahead Give user log types a tokenizer and datasource instead of a page of checkboxes 2019-07-24 07:11:42 -07:00
userlog Record account recovery email links in the user activity log and make the mail message reference the log 2019-07-24 07:13:34 -07:00
view Render user hovercards with context information about their ability to see the context object 2021-02-13 13:37:37 -08:00
xaction Remove product literal strings in "pht()", part 7 2022-04-25 12:22:28 -07:00