1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-01 09:28:22 +01:00
phorge-phorge/src/applications/diffusion/xaction
epriestley bab35f28e4 Respect repository identities when selecting author vs auditor actions
Summary:
Depends on D20580. Fixes T13311. When we choose which actions to show a user, we can either show them "auditor" actions (like "raise concern") or "author" actions (like "request verification").

Currently, we don't show "author" actions if you're the author of the commit via an identity mapping, but we should. Use identity mappings where they exist.

(Because I've implemented `getEffectiveAuthorPHID()` in a way that requires `$data` be attached, it's possible this will make something throw a "DataNotAttached" exception, but: probably it won't?; and that's easy to fix if it happens.)

Test Plan:
See D20580. As `@alice`, viewed the commit in the UI.

  - Before: got auditor actions presented to me.
  - After: got author actions.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13311

Differential Revision: https://secure.phabricator.com/D20581
2019-06-17 13:56:38 -07:00
..
DiffusionCommitAcceptTransaction.php Expose Audit actions for "transaction.search" in a basic way 2018-10-27 07:19:50 -07:00
DiffusionCommitActionTransaction.php Respect repository identities when selecting author vs auditor actions 2019-06-17 13:56:38 -07:00
DiffusionCommitAuditorsTransaction.php Merge multiple Auditors transactions from Herald 2017-02-23 15:14:58 -08:00
DiffusionCommitAuditTransaction.php Add a "Needs Verification" state to Audit 2017-01-25 13:08:59 -08:00
DiffusionCommitBuildableTransaction.php Provide a modular buildable transaction in Diffusion 2018-04-03 11:01:37 -07:00
DiffusionCommitConcernTransaction.php Expose Audit actions for "transaction.search" in a basic way 2018-10-27 07:19:50 -07:00
DiffusionCommitResignTransaction.php Expose Audit actions for "transaction.search" in a basic way 2018-10-27 07:19:50 -07:00
DiffusionCommitStateTransaction.php Rename "PhabricatorAuditCommitStatusConstants" to "DiffusionCommitAuditStatus"; remove "MODERN_" 2018-09-12 12:44:43 -07:00
DiffusionCommitTransactionType.php Add modern "Accept", "Raise Concern" and "Resign" transactions to Audit 2017-01-11 13:56:48 -08:00
DiffusionCommitVerifyTransaction.php Expose Audit actions for "transaction.search" in a basic way 2018-10-27 07:19:50 -07:00