revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-03 04:02:43 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 3e0391c574 Don't mark subscribes/mentions as "Lock Overridden" 
Summary:
See PHI1209. When a task is in "Hard Lock" mode, it's still possible to apply some changes to it. Notably:

  - You can subscribe/unsubscribe.
  - You can mention it on another object.
  - You can add a relationship from some other object to it (e.g., select it as a "Parent Task" for some other task).

Currently, these types of edits will show a "Lock Overridden" timeline emblem icon. However, they should not: you didn't override a lock to make these changes, they just bypass locks.

For now, special case these cases (self subscribe/unsubscribe + inverse edge edits) so they don't get the little icon, since I think this list is exhaustive today.

Some day we should modularize this, but we'd need code like this anyway (since TYPE_SUBSCRIBE is not modular yet), and this seems unlikely to cause problems even if it's a bit rough.

Test Plan:
  - Hard-locked a task.
    - Subscribed/unsubscribed, mentioned, relationship'd it as a non-author. No timeline emblems.
  - Soft-locked a task.
    - Subscribed/unsubscribed, mentioned, relationship'd it, no timeline emblems.
    - Clicked "Edit", answered "yes" to the override prompt, edited it. Got a timeline emblem.
  - Added some comments and stuff to a normal non-locked task, no emblems.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20513
2019-05-14 09:27:24 -07:00
..
almanac Convert complex query subclasses to use internal cursors 2019-03-19 13:02:16 -07:00
aphlict Add a CLI workflow for testing that notifications are being delivered 2018-12-10 16:05:53 -08:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Unify code for parsing "Reverts X" magic, and when something "reverts <hash>", also revert associated revisions 2019-05-01 09:47:40 -07:00
auth Set a URI on Auth Messages, so the "Change Details" dialog from the transaction record has a cancel button 2019-04-30 06:59:04 -07:00
badges Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
base Don't show a "Manage" button in Legalpad if the user is signing a TOS document 2019-03-25 11:30:46 -07:00
cache Remove an old digest in Celerity code and some obsolete configuration options 2019-01-04 13:43:38 -08:00
calendar Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
celerity Fix "Actions" button on Phame standalone/live pages (bonus: JX.sprintf()) 2019-04-04 06:10:14 -07:00
chatlog Replace "getRequestURI()->setQueryParams(array())" with "getPath()" 2019-02-12 14:43:33 -08:00
conduit Fix an exception with user cache generation in "bin/conduit call --as <user>" 2019-03-07 11:48:24 -08:00
config Don't warn about a locked database value after users run "bin/auth lock" 2019-04-17 19:54:11 -07:00
conpherence Improve Conpherence behavior for logged out users. 2019-04-02 14:03:08 -07:00
console Fix some minor errors (DarkConsole warning, unstable Ferret sort) 2018-03-18 15:12:25 -07:00
countdown Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
daemon Track total time from task creation to task archival 2019-02-20 14:44:29 -08:00
dashboard Add "Move Left" and "Move Right" to dashboard tab panels 2019-05-01 15:35:53 -07:00
differential Fix a HunkParser typo, "identcal" -> "identical" 2019-05-07 11:16:55 -07:00
diffusion Fix the direction of the commit/revision edge 2019-05-02 07:28:49 -07:00
diviner Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
doorkeeper Allow Doorkeeper references to have multiple display variations (full, short, etc.) 2018-03-13 11:29:52 -07:00
draft/storage When purging drafts after a transaction edit, purge all drafts 2018-02-11 06:01:09 -08:00
drydock Fix a typo in Drydock "Land" operations 2019-03-15 14:53:05 -07:00
fact Simplify implementation of "pure" Chart functions 2019-04-23 12:29:45 -07:00
favorites Make "Favorites" work more like other customizable menus 2019-04-09 13:59:35 -07:00
feed Fix "before/after" cursor paging for API call "feed.query" 2019-04-23 11:51:16 -07:00
files Replace all "setQueryParam()" calls with "remove/replaceQueryParam()" 2019-02-14 11:56:39 -08:00
flag Update many Phabricator queries for new %Q query semantics 2018-11-15 03:48:10 -08:00
fund Improve UI/UX when users try to add an invalid card with Stripe 2019-02-09 05:54:42 -08:00
guides Remove legacy "DashboardInstall" table 2019-04-14 10:27:52 -07:00
harbormaster Provide a clearer UI for "view all results" in partial result panels 2019-03-25 14:35:08 -07:00
help Redesign header menus and search 2017-01-17 12:13:06 -08:00
herald Index and surface usage sites for Dashboards 2019-04-12 06:13:44 -07:00
home Make "Favorites" work more like other customizable menus 2019-04-09 13:59:35 -07:00
legalpad Don't show a "Manage" button in Legalpad if the user is signing a TOS document 2019-03-25 11:30:46 -07:00
lipsum Add "--force" and "--quickly" flags to bin/lipsum 2017-02-27 09:09:41 -08:00
macro Improve timeline rendering for old macros 2019-04-18 18:25:17 -07:00
maniphest Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest > Reports" working 2019-04-19 07:05:37 -07:00
meta Fix an issue where internal paging of notifications could fail if some notifications are not visible 2019-04-23 11:45:04 -07:00
metamta Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in "cluster.mailers" 2019-03-16 12:35:55 -07:00
multimeter Fix a PhutilURI issue in Multimeter 2019-02-17 17:39:34 -08:00
notification Add "Move Left" and "Move Right" to dashboard tab panels 2019-05-01 15:35:53 -07:00
nuance Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface 2018-12-20 15:16:19 -08:00
oauthserver Replace all "setQueryParam()" calls with "remove/replaceQueryParam()" 2019-02-14 11:56:39 -08:00
owners Index and show Owners packages affected by Herald rules 2019-04-17 12:17:30 -07:00
packages Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface 2018-12-20 15:16:19 -08:00
passphrase Make the default behavior of getApplicationTransactionCommentObject() "return null" instead of "throw" 2019-02-07 14:56:38 -08:00
paste Remove "metamta.*.subject-prefix" options 2019-01-17 19:18:50 -08:00
people Fix some overlooked profile menu construction callsites 2019-04-09 14:47:44 -07:00
phame Fix "Actions" button on Phame standalone/live pages (bonus: JX.sprintf()) 2019-04-04 06:10:14 -07:00
phid Update search indexes for Dashboards and Panels to Ferret, plus various minor fixes 2019-04-14 10:28:19 -07:00
phlux Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
pholio Replace all "setQueryParam()" calls with "remove/replaceQueryParam()" 2019-02-14 11:56:39 -08:00
phortune Remove WePay support from Phortune, and Restful/Httpful dependencies 2019-05-14 09:14:53 -07:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phragment Update many Phabricator queries for new %Q query semantics 2018-11-15 03:48:10 -08:00
phrequent Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
phriction Make Portals indexable with Ferret 2019-04-10 13:33:54 -07:00
phurl Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
policy Update "bin/policy unlock" to be more surgical, flexible, modular, and modern 2019-03-07 12:24:25 -08:00
ponder Fix a missing pht() in Ponder 2019-04-12 12:18:56 -07:00
project Fix a fatal when navigating to a Workboard after removing the Workboard menu item 2019-05-14 09:26:02 -07:00
releeph Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
remarkup/conduit
repository Consolidate readers of "differential.revisionID" property 2019-05-01 09:46:17 -07:00
search Add a "Customize Query" action to query panels to make it easier to make minor query adjustments 2019-05-01 11:01:09 -07:00
settings Fix two minor timezone display issues 2019-03-25 10:53:36 -07:00
slowvote Fix two very, very minor correctness issues in Slowvote 2019-02-07 12:45:11 -08:00
spaces Make the default behavior of getApplicationTransactionCommentObject() "return null" instead of "throw" 2019-02-07 14:56:38 -08:00
subscriptions Index and show Owners packages affected by Herald rules 2019-04-17 12:17:30 -07:00
support/application
system Allow objects to specify custom policy unlocking behavior, and tasks to have owners unlocked 2019-03-07 12:27:11 -08:00
tokens Allow tokens to be awarded to MFA-required objects 2018-12-28 00:14:48 -08:00
transactions Don't mark subscribes/mentions as "Lock Overridden" 2019-05-14 09:27:24 -07:00
typeahead Make Portals indexable with Ferret 2019-04-10 13:33:54 -07:00
uiexample Reduce the cost of generating default user profile images 2018-03-01 16:53:17 -08:00
xhprof Allow XHProf profiles to be drag-and-dropped to upload them 2017-02-23 11:16:19 -08:00