1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-20 20:40:56 +01:00
phorge-phorge/src/applications/files/controller
Bob Trahan 3ef0721ada Reduce PhabricatorUser::getOmnipotentUser calls by adding a getViewer method to PhbaricatorDestructionEngine
Summary:
Fixes T6956. Before this change, we called PhabricatorUser::getOmnipotentUser in the various delete methods to query the data. Now, we use $engine->getViewer(), since its always a good thing to have less calls to PhabricatorUser::getOmnipotentUser thrown around the codebase.

I used the "codemod" tool to audit the existing calls to PhabricatorDestructorEngine (all of them) so ostensibly this gets all the spots. If I missed something though, its still going to work, so this change is very low risk.

Test Plan: ./bin/remove destroy P1; visit P1 and get a 404

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6956

Differential Revision: https://secure.phabricator.com/D12866
2015-05-15 14:07:17 -07:00
..
PhabricatorFileCommentController.php Transactions - hide "mentioned in X" story if you can't see X 2014-09-16 12:12:35 -07:00
PhabricatorFileComposeController.php Use __CLASS__ instead of hard-coding class names 2015-05-14 07:21:13 +10:00
PhabricatorFileController.php Increase visibility of PhabricatorController::buildApplicationMenu methods 2015-01-16 07:41:26 +11:00
PhabricatorFileDataController.php Use PhutilInvalidStateException 2015-05-14 07:53:52 +10:00
PhabricatorFileDeleteController.php Make most file reads policy-aware 2013-09-30 09:38:13 -07:00
PhabricatorFileDropUploadController.php Enable the chunk storage engine 2015-03-15 11:37:05 -07:00
PhabricatorFileEditController.php File names should be editable. 2015-04-26 15:24:29 -07:00
PhabricatorFileInfoController.php Convert inline profile image transforms to new transformations 2015-05-13 11:38:46 -07:00
PhabricatorFileListController.php Quicksand - make things work correctly with global drag and drop upload 2015-04-23 15:08:35 -07:00
PhabricatorFileTransformController.php Reduce PhabricatorUser::getOmnipotentUser calls by adding a getViewer method to PhbaricatorDestructionEngine 2015-05-15 14:07:17 -07:00
PhabricatorFileTransformListController.php Implement new profile transform with amazing "error handling" feature 2015-05-13 11:38:45 -07:00
PhabricatorFileUploadController.php Quicksand - make things work correctly with global drag and drop upload 2015-04-23 15:08:35 -07:00
PhabricatorFileUploadDialogController.php Rename "Upload Image" dialog to "Upload File" to match purpose 2013-10-11 05:15:45 -07:00