1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications
epriestley 440ef5b7a7 Remove SHA1 file content hashing and make Files work without any hashing
Summary:
Ref T12464. We currently use SHA1 to detect when two files have the same content so we don't have to store two copies of the data.

Now that a SHA1 collision is known, this is theoretically dangerous. T12464 describes the shape of a possible attack.

Before replacing this with something more robust, shore things up so things work correctly if we don't hash at all. This mechanism is entirely optional; it only helps us store less data if some files are duplicates.

(This mechanism is also less important now than it once was, before we added temporary files.)

Test Plan: Uploaded multiple identical files, saw the uploads work and the files store separate copies of the same data.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12464

Differential Revision: https://secure.phabricator.com/D17619
2017-04-04 16:22:10 -07:00
..
almanac Cache Almanac URIs for repositories 2016-12-06 09:14:45 -08:00
aphlict
arcanist/conduit
audit Restrict Audit buckets to just ApplicationSearch views 2017-03-23 12:46:19 -07:00
auth Remove PhabricatorFile::buildFromFileDataOrHash() 2017-04-04 16:18:00 -07:00
badges Move Files to ModularTransactions 2017-04-04 10:25:05 -07:00
base Fix errors found by PHPStan 2017-02-17 10:10:15 +00:00
cache With APCu 5+, use apcu_* function to examine cache state 2017-01-12 15:59:44 -08:00
calendar When destroying Calendar events, destroy invitees and notifications 2017-03-24 09:21:13 -07:00
celerity Add a "Red/Green Colorblind" accessibility mode, make all web UIs and email respect it 2017-02-23 10:57:39 -08:00
chatlog
conduit Provide a hint that submitting a Conduit call shows you how to encode particular parameters 2017-03-24 13:15:03 -07:00
config Rename "ElasticSearch" filenames to "Elasticsearch" (2/2) 2017-04-02 14:59:36 -07:00
conpherence Reduce application search engine results list for Dashboards 2017-02-22 12:42:43 -08:00
console
countdown
daemon Give Daemons a mobile menu 2017-03-24 09:19:56 -07:00
dashboard Provide a 'no dashboards' fallback state if you can't add any 2017-03-21 11:43:02 -07:00
differential Remove PhabricatorFile::buildFromFileDataOrHash() 2017-04-04 16:18:00 -07:00
diffusion Make the Files "TTL" API more structured 2017-04-04 16:16:28 -07:00
diviner Fix a constant typo in Diviner ("DECLARATAION" -> "TION") 2017-03-04 09:54:10 -08:00
doorkeeper
draft/storage
drydock
fact
favorites Add some style to label in Favorites Menu 2017-02-01 07:20:31 -08:00
feed
files Remove SHA1 file content hashing and make Files work without any hashing 2017-04-04 16:22:10 -07:00
flag Remove counts from home navigation 2017-01-21 13:55:40 -08:00
fund
guides
harbormaster Navigage Buildkite builds with more nuance 2017-01-31 17:26:45 -08:00
help Redesign header menus and search 2017-01-17 12:13:06 -08:00
herald Reduce application search engine results list for Dashboards 2017-02-22 12:42:43 -08:00
home Fix italics issue with nux state on homepage 2017-02-25 15:30:17 -08:00
legalpad Fix errors found by PHPStan 2017-02-17 10:10:15 +00:00
lipsum Add "--force" and "--quickly" flags to bin/lipsum 2017-02-27 09:09:41 -08:00
macro Fix display of current file on Macro creation 2017-02-03 17:10:02 -08:00
maniphest Expose the commit/task/revision relationship edges to "edge.search" 2017-04-02 19:49:55 -07:00
meta Redesign Home/Profile/Projects side navigation 2017-01-31 08:59:01 -08:00
metamta Allow "bin/mail send-test" to accept raw email addresses via "--to" 2017-03-10 14:52:33 -08:00
multimeter
notification
nuance
oauthserver Reduce application search engine results list for Dashboards 2017-02-22 12:42:43 -08:00
owners Allow Owner Packages to be in a Dashboard Panel 2017-03-30 15:13:40 -07:00
packages Reduce application search engine results list for Dashboards 2017-02-22 12:42:43 -08:00
passphrase
paste Get line count before truncating Paste snippets 2017-03-01 22:30:18 +00:00
people Paginate the profile badges view 2017-03-24 14:10:59 -07:00
phame Fix errors found by PHPStan 2017-02-17 10:10:15 +00:00
phid Fix errors found by PHPStan 2017-02-17 10:10:15 +00:00
phlux
pholio Make bin/lipsum generate hanldle generator keys and arguments more clearly 2017-02-27 09:09:28 -08:00
phortune Update PhortuneLanding page UI 2017-03-30 12:27:41 -07:00
phpast
phragment Remove PhabricatorFile::buildFromFileDataOrHash() 2017-04-04 16:18:00 -07:00
phrequent Allow Phrequent to be used in dashboard panels 2017-03-06 11:00:55 -08:00
phriction Fix errors found by PHPStan 2017-02-17 10:10:15 +00:00
phurl Update Phurl for modular transactions 2017-02-24 08:30:47 -08:00
policy Make "Can Interact" and logged-out users interact more gracefully 2017-03-09 08:50:57 -08:00
ponder Fix errors found by PHPStan 2017-02-17 10:10:15 +00:00
project Remove FIELD_KEYWORDS, index project slugs as body content 2017-04-02 09:36:32 -07:00
releeph Reduce application search engine results list for Dashboards 2017-02-22 12:42:43 -08:00
remarkup/conduit
repository Add repositories to fulltext search index. 2017-03-28 07:58:22 +00:00
search Rename "ElasticSearch" filenames to "Elasticsearch" (2/2) 2017-04-02 14:59:36 -07:00
settings Fix bad JS rendering in "Allow Desktop Notifications" workflow 2017-02-20 12:55:34 -08:00
slowvote Fix errors found by PHPStan 2017-02-17 10:10:15 +00:00
spaces Fix errors found by PHPStan 2017-02-17 10:10:15 +00:00
subscriptions Allow task statuses to "lock" them, preventing additional comments and interactions 2017-03-02 16:57:10 -08:00
support/application
system Cache Almanac URIs for repositories 2016-12-06 09:14:45 -08:00
tokens Prevent awarding/revoking tokens when a task is locked 2017-03-04 09:55:35 -08:00
transactions Provide a missing feed transaction string for space creation 2017-04-04 10:24:11 -07:00
typeahead Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine 2016-12-16 10:08:49 -08:00
uiexample Fix two typos ("Adminstrator", "Recipents") 2017-03-12 14:23:43 -07:00
xhprof Allow XHProf profiles to be drag-and-dropped to upload them 2017-02-23 11:16:19 -08:00