revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-09 06:11:01 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/differential
History
epriestley 4b2a447003 Allow "has draft inlines?" queries to overheat 
Summary:
Ref T13513. If your 10 most recently authored inlines have all been deleted, these queries can fail by overheating. This is silly and probably rarely happens outside of development.

For now, just let them overheat. This may create a false negative (incorrect "no draft" signal when the real condition is "drafts, but 10 most recent comments were deleted"). This could be sorted out later with a query mode like "executeAny()", perhaps.

Test Plan:
  - Created and deleted 10 inlines.
  - Submitted comments.
  - Before: overheating fatal during draft flag generation.
  - After: clean submission.

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21274
2020-05-20 14:25:34 -07:00
..
__tests__ Make "Highlight As..." sticky across reloads in Diffusion and Differential 2020-04-19 08:58:39 -07:00
application Add a test to verify that all routing maps are plausibly valid, and remove some dead routes 2020-02-14 18:06:24 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
command Fix another stray "msort()/msortv()" issue 2019-06-17 13:20:10 -07:00
conduit Make the "attach_inlines" parameter to "differential.createcomment" a no-op 2020-05-07 15:55:37 -07:00
config Remove all whitespace options/configuration everywhere 2019-02-19 13:09:29 -08:00
constants Update the diff table of contents to use hierarchical views and edit distance renames 2020-04-28 12:27:37 -07:00
controller Fix an issue where storage inlines are fed to InlineAdjustmentEngine 2020-05-08 16:55:54 -07:00
customfield Fix some PHP 7.4 array index access issues 2020-04-26 08:35:06 -07:00
doorkeeper Remove "metamta.*.subject-prefix" options 2019-01-17 19:18:50 -08:00
edge Update parent/child revision timeline messages to use modern language ("parent revision") 2018-07-13 09:02:10 -07:00
editor Replace "loadUnsubmittedInlineComments()" with a modern "DiffQuery" 2020-05-07 16:11:02 -07:00
engine Allow "has draft inlines?" queries to overheat 2020-05-20 14:25:34 -07:00
engineextension Add a "commits" attachment to "differential.diff.search" for retrieving local commit information 2018-04-19 17:25:06 -07:00
exception Remove an unused class 2015-01-03 09:07:32 +11:00
field Move misplaced validation for ambiguous fields in "Test Plan" to the right place 2017-06-30 06:36:05 -07:00
garbagecollector Add a very forgiving GC for Differential viewstate information 2020-04-23 14:17:48 -07:00
harbormaster Don't try to publish build results to bare diffs 2019-02-13 12:19:29 -08:00
herald Implement an "Author's packages" Herald field for Differential 2020-01-22 18:27:51 -08:00
lipsum Fix deprecated argument order for "implode()" 2019-10-17 09:11:27 -07:00
mail Update out-of-date API calls when rendering diffs inline in email 2020-05-19 10:39:58 -07:00
management For changesets that affect binaries, use the new binary file content hash as an effect hash 2020-04-27 08:34:55 -07:00
parser Fix an unusual issue with intradiff highlighting of files with uncommon end-of-file modifications 2020-05-19 09:06:19 -07:00
phid Remove "State Icons" from handles 2019-10-31 12:04:43 -07:00
query Replace "loadUnsubmittedInlineComments()" with a modern "DiffQuery" 2020-05-07 16:11:02 -07:00
relationships Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
render Improve offset/range inline behavior for rich diffs and unified diffs 2020-05-14 16:02:32 -07:00
search Remove Ferret function aliases and overrides 2020-04-16 13:40:17 -07:00
storage Allow inline comment storage objects to generate their own runtime objects 2020-05-07 15:57:49 -07:00
typeahead Support "none()" in Differential to find revisions with no (un-resigned) reviewers 2019-05-21 12:56:59 -07:00
view Allow users to create inline comments by directly selecting text directly 2020-05-13 17:15:18 -07:00
xaction Make "editing" state persistent for inline comments 2020-05-04 13:10:30 -07:00
DifferentialGetWorkingCopy.php Extend from Phobject 2015-06-15 18:02:27 +10:00