1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 03:12:41 +01:00
phorge-phorge/src/applications/herald
epriestley 5a604538ca Fix an initialization issue in Herald rules in Chrome
Summary:
Fixes T10646. When you load the page or click "New Condition" or "New Action", we try to add a condition and action with some default values.

Currently, the logic just sets everything to `null` or `'default'`. This technically works in Safari, but is less successful in Chrome. (I think Safari prevents you from picking an invalid value.)

Instead of relying on the browser to pick the right value, set the correct value explicitly.

Test Plan:
  - Created a new rule in Chrome, Safari.
  - Added fields and conditions in Chrome, Safari.
  - Edited existing rules in Chrome, Safari.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10646

Differential Revision: https://secure.phabricator.com/D15507
2016-03-22 09:13:51 -07:00
..
action Allow "Assign task" Herald Action in Maniphest to accept "None" to unassign 2015-12-05 12:39:45 -08:00
adapter Add "does not match regexp" to Herald 2016-02-11 15:29:38 -08:00
application Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
config Extend from Phobject 2015-06-15 18:02:27 +10:00
controller Fix an initialization issue in Herald rules in Chrome 2016-03-22 09:13:51 -07:00
editor Modularize mail tags 2014-08-12 12:28:41 -07:00
engine Fix an issue with the Herald engine field value cache 2016-03-09 10:28:50 -08:00
engineextension Fully modularize DestructionEngine 2015-12-21 17:03:44 -08:00
field Add "does not match regexp" to Herald 2016-02-11 15:29:38 -08:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
group Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00
phid Add PHIDType for HeraldTransaction 2016-01-15 16:40:48 +00:00
query Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
storage Remove shouldShowSubscribersProperty() from SubscribableInterface 2016-03-06 06:01:36 -08:00
value Improve rendering of tokenizer tokens in Herald when editing rules 2015-12-05 11:20:07 -08:00