revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 03:12:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 4dc857e36d Fix an issue with incorrect split head detection in Mercurial after pushing a medley of varied changes 
Summary:
Fixes T10665. See that task for discussion.

Because `$head_map` is not properly re-initialized for each ref we check, pushes which affect multiple branches (say, "A" and "B") can have information bleed from the first branch check to the second branch.

To trigger a problem behavior, you can push one commit which updates an existing branch, plus one commit which creates a new branch. If they process in the right order, the `$head_map` from the updated branch will bleed into the `$head_map` for the new branch and trigger an incorrect head split detection.

Test Plan:
  - Pushed a set of changes which updated `branch-a` and created `branch-b`.
    - Before change: improper detection of split heads.
    - After change: clean push.
  - Pushed a set of changes which split the head of `branch-d`.
    - Correct detection of split heads.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10665

Differential Revision: https://secure.phabricator.com/D15522
2016-03-25 07:33:55 -07:00
..
almanac Provide bin/nuance import and ngram indexes for sources 2016-03-08 10:30:24 -08:00
aphlict Update "should not run as root" message 2015-10-31 11:20:23 +00:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Add icons/colors to Audit transactions 2016-03-17 14:19:46 -07:00
auth Convert OAuth1 handshake tokens to new modular temporary tokens 2016-03-16 09:34:18 -07:00
badges Convert every two-column application except Maniphest to curtain views 2016-03-06 10:44:07 -08:00
base Convert every two-column application except Maniphest to curtain views 2016-03-06 10:44:07 -08:00
cache Write 500 words on how to restart webservers 2015-12-02 09:16:10 -08:00
calendar Add back calendar comment form 2016-03-08 08:06:54 -08:00
celerity Polish up timeline for PHIUTwoColumnView 2016-03-08 17:51:53 -08:00
chatlog Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
conduit fix the typo in the label field 2016-02-16 15:14:19 -08:00
config Add amazon-ses.endpoint configuration 2016-03-23 12:28:59 -07:00
conpherence Expand scope of addActionItem in PHUIHeaderView 2016-03-04 18:35:05 -08:00
console Separate external editor integration from callsigns 2016-01-04 06:54:01 -08:00
countdown Convert every two-column application except Maniphest to curtain views 2016-03-06 10:44:07 -08:00
daemon Make bin/phd debug quieter by default 2016-03-07 08:04:49 -08:00
dashboard Expand scope of addActionItem in PHUIHeaderView 2016-03-04 18:35:05 -08:00
differential Add a "Build with CircleCI" build step 2016-03-22 12:12:11 -07:00
diffusion Fix an issue with incorrect split head detection in Mercurial after pushing a medley of varied changes 2016-03-25 07:33:55 -07:00
diviner Restrict PropertyListView width to just DocumentProView 2016-02-22 11:54:23 -08:00
doorkeeper Kinda start bridging data in from GitHub via Nuance 2016-03-24 05:18:18 -07:00
draft/storage Fix EditEngine preview/draft for first comment on a task you didn't create 2015-12-05 09:57:45 -08:00
drydock Convert Drydock to two column layout 2016-03-13 08:10:36 -07:00
fact Swap charts from gRaphael to D3 2016-02-01 10:36:59 -08:00
feed Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
files Support pushing data into Git LFS 2016-03-18 09:36:34 -07:00
flag Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
fund Convert every two-column application except Maniphest to curtain views 2016-03-06 10:44:07 -08:00
harbormaster Add a CircleCI webhook 2016-03-22 12:12:36 -07:00
help Begin modularizing main menu items 2016-01-04 06:57:09 -08:00
herald Fix an initialization issue in Herald rules in Chrome 2016-03-22 09:13:51 -07:00
home Expand scope of addActionItem in PHUIHeaderView 2016-03-04 18:35:05 -08:00
legalpad Remove shouldShowSubscribersProperty() from SubscribableInterface 2016-03-06 06:01:36 -08:00
lipsum Improve lispum generation of pastes 2015-12-25 07:41:38 -08:00
macro Convert every two-column application except Maniphest to curtain views 2016-03-06 10:44:07 -08:00
maniphest Introduce "bridged" objects 2016-03-22 15:06:57 -07:00
meta Convert every two-column application except Maniphest to curtain views 2016-03-06 10:44:07 -08:00
metamta Add amazon-ses.endpoint configuration 2016-03-23 12:28:59 -07:00
multimeter Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
notification Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
nuance Improve rendering of many GitHub event strings 2016-03-24 08:57:42 -07:00
oauthserver Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
owners Provide bin/nuance import and ngram indexes for sources 2016-03-08 10:30:24 -08:00
passphrase Attach credential impelementations when initializing new credentials 2016-03-22 18:53:09 -07:00
paste Introduce "Curtain" views, panels, and extensions 2016-03-06 09:27:55 -08:00
people Make dates/times more concise in Diffusion 2016-03-18 09:11:09 -07:00
phame Give AphrontTagView a getViewer(), deprecate getUser() 2016-03-06 09:27:38 -08:00
phid Fix tag limit logic in PHUIHandleTagListView 2016-03-22 09:29:14 -07:00
phlux Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
pholio Remove shouldShowSubscribersProperty() from SubscribableInterface 2016-03-06 06:01:36 -08:00
phortune Fix Phortune Subscription high-security checkpoint URI 2016-03-23 12:08:38 -07:00
phpast Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
phragment Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
phrequent Add a Phrequent curtain extension 2016-03-10 18:45:04 -08:00
phriction Remove shouldShowSubscribersProperty() from SubscribableInterface 2016-03-06 06:01:36 -08:00
phurl When marking up Phurl URLs for mail, use absolute URLs 2016-03-18 16:00:31 -07:00
policy Simplify locking of Almanac cluster services 2016-02-25 03:38:39 -08:00
ponder Convert every two-column application except Maniphest to curtain views 2016-03-06 10:44:07 -08:00
project Update project manage page for two column 2016-03-09 09:11:48 -08:00
releeph Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
remarkup/conduit phtize all the things 2015-05-22 21:16:39 +10:00
repository Add a "Build with CircleCI" build step 2016-03-22 12:12:11 -07:00
search Update Buildable search in Harbormaster 2016-02-27 07:13:10 -08:00
settings Make temporary token storage/schema more flexible 2016-03-16 09:33:38 -07:00
slowvote Convert every two-column application except Maniphest to curtain views 2016-03-06 10:44:07 -08:00
spaces Convert Spaces to two column 2016-03-21 13:02:54 -07:00
subscriptions Introduce "Curtain" views, panels, and extensions 2016-03-06 09:27:55 -08:00
support/application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
system Fully modularize DestructionEngine 2015-12-21 17:03:44 -08:00
tokens Introduce "Curtain" views, panels, and extensions 2016-03-06 09:27:55 -08:00
transactions Allow applications to test if a user could edit a certain field by clicking "Edit Thing" 2016-03-08 10:29:34 -08:00
typeahead Allow Almanac interfaces to be browsed 2016-02-21 10:45:00 -08:00
uiexample Update to use PHUIRemarkupView everywhere possible 2016-02-16 14:05:53 -08:00
xhprof Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00