revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 500506bfef Persist excluded recipients when saving mail 
Summary:
Fixes T5185. The fundamental issue is that this `excludePHIDs` property was not saved, so the logic went like this:

  - Generate `excludePHIDs` correctly.
  - Pass `excludePHIDs` through the stack.
  - Perform some other computations correctly.
  - Queue the mail for the daemons, throwing it away. {icon bomb}
  - Daemons process mail with empty `excludePHIDs` list.

Store it in the persistent properties array instead.

Also remove the "override self mail" thing, since it's only used by `bin/mail send-test` and suffers from the same issue. I think it's too useless to fix, since even if you get caught by it, `bin/mail` makes it clear why the message was dropped.

Test Plan:
Notable:

  - `exclude` present in properties
  - Exclusion reason under RECIPIENTS header

{P1229}

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5185

Differential Revision: https://secure.phabricator.com/D10234
2014-08-12 12:28:07 -07:00
..
aphlict/management Try nodejs before node when starting notification server 2014-06-07 13:56:23 -07:00
arcanist/conduit Rename Conduit classes 2014-07-25 10:54:15 +10:00
audit Fix several issues with application interactions while importing commits 2014-08-11 12:08:24 -07:00
auth Don't send reset links to unverified addresses on accounts with verified addresses 2014-08-11 12:13:09 -07:00
base Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
cache Rename PhutilKeyValueCache subclasses 2014-08-06 08:12:28 +10:00
calendar Events - add a byline to event list 2014-08-06 15:04:12 -07:00
chatlog Fix some missing renames of Application classes 2014-07-24 18:03:59 -07:00
conduit Fix string construction in Conduit exceptions 2014-08-11 12:08:06 -07:00
config Rename AphrontQueryException subclasses 2014-08-06 07:51:21 +10:00
conpherence Rename Conduit classes 2014-07-25 10:54:15 +10:00
countdown Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
daemon Send graceful shutdown signals to daemons in Phabricator 2014-08-11 20:18:31 -07:00
dashboard Fix dashboard list if there are no results 2014-08-09 19:08:16 -07:00
differential Fix several issues with application interactions while importing commits 2014-08-11 12:08:24 -07:00
diffusion Allow repo updates to recover after force push + garbage collection 2014-08-12 12:25:24 -07:00
diviner Rename PhutilKeyValueCache subclasses 2014-08-06 08:12:28 +10:00
doorkeeper Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
draft/storage Differential - add DifferentialDraft to track whether revisions have draft feedback or not 2014-02-18 16:25:16 -08:00
drydock Allow timeouts to be specified on Drydock SSH connections 2014-08-12 09:14:47 +10:00
fact Send graceful shutdown signals to daemons in Phabricator 2014-08-11 20:18:31 -07:00
feed Fix some missing renames of Application classes 2014-07-24 18:03:59 -07:00
files Consolidate handling of special properties for newly uploaded files 2014-08-11 09:39:40 -07:00
flag Rename Conduit classes 2014-07-25 10:54:15 +10:00
harbormaster Implement artifact release for Harbormaster 2014-08-12 09:15:16 +10:00
help Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
herald T5423, "is newly created" herald rule fails on dry runs 2014-08-07 17:04:41 -07:00
home Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
legalpad Fix "legalpad documents" typeahead dataousource 2014-08-08 11:38:18 -07:00
lipsum Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00
macro Add a CanCDN flag to uploaded files 2014-08-07 18:56:20 -07:00
mailinglists Rename AphrontQueryException subclasses 2014-08-06 07:51:21 +10:00
maniphest Use transactions properly when building tasks from email 2014-08-12 12:25:47 -07:00
meta Rename PHIDType classes 2014-07-24 08:05:46 +10:00
metamta Persist excluded recipients when saving mail 2014-08-12 12:28:07 -07:00
notification Notifications - fix race condition around "Mark All Read". 2014-08-01 16:39:05 -07:00
nuance Fix some missing renames of Application classes 2014-07-24 18:03:59 -07:00
oauthserver Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
owners Rename AphrontQueryException subclasses 2014-08-06 07:51:21 +10:00
passphrase T5409, allow bin/remove to permanently destroy credential and everything associated with it 2014-08-07 16:33:54 -07:00
paste Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
people Add a CanCDN flag to uploaded files 2014-08-07 18:56:20 -07:00
phame Remove "Edit" text on Phame 2014-08-08 10:02:22 -07:00
phid Remove PHID_TYPE_ACMT 2014-08-05 12:02:22 -07:00
phlux Rename AphrontQueryException subclasses 2014-08-06 07:51:21 +10:00
pholio Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
phortune Show a very basic purchase history in Phortune 2014-08-11 12:10:09 -07:00
phpast Add some missing application names 2014-07-23 08:15:44 -07:00
phragment Correct typo: security.alter[n]ate-file-domain 2014-08-07 09:41:20 -07:00
phrequent Account for preempting events on the Phrequent list view 2014-08-11 12:30:48 -07:00
phriction Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
policy Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
ponder Fix broken handle rendering in Ponder 2014-08-12 12:25:58 -07:00
project Allow projects to be filtered by icon and color 2014-08-12 08:04:38 -07:00
releeph Rename AphrontQueryException subclasses 2014-08-06 07:51:21 +10:00
remarkup/conduit Rename Conduit classes 2014-07-25 10:54:15 +10:00
repository Allow repo updates to recover after force push + garbage collection 2014-08-12 12:25:24 -07:00
search Rename AphrontQueryException subclasses 2014-08-06 07:51:21 +10:00
settings Settings - upgrade monospace font regexp to support '.' 2014-08-06 13:53:30 -07:00
slowvote Slowvote - add ability to destroy a poll 2014-08-06 14:19:37 -07:00
subscriptions Rename PHIDType classes 2014-07-24 08:05:46 +10:00
support/application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
system T5409, allow bin/remove to permanently destroy credential and everything associated with it 2014-08-07 16:33:54 -07:00
tokens Rename Conduit classes 2014-07-25 10:54:15 +10:00
transactions Publish stories about objects in projects as related to projects 2014-08-12 12:27:24 -07:00
typeahead Implement build simulation; convert Harbormaster to be purely dependency based 2014-07-31 11:39:49 +10:00
uiexample Rename PHIDType classes 2014-07-24 08:05:46 +10:00
xhprof Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00