1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 17:52:43 +01:00
phorge-phorge/src/applications/metamta/management
epriestley 500506bfef Persist excluded recipients when saving mail
Summary:
Fixes T5185. The fundamental issue is that this `excludePHIDs` property was not saved, so the logic went like this:

  - Generate `excludePHIDs` correctly.
  - Pass `excludePHIDs` through the stack.
  - Perform some other computations correctly.
  - Queue the mail for the daemons, throwing it away. {icon bomb}
  - Daemons process mail with empty `excludePHIDs` list.

Store it in the persistent properties array instead.

Also remove the "override self mail" thing, since it's only used by `bin/mail send-test` and suffers from the same issue. I think it's too useless to fix, since even if you get caught by it, `bin/mail` makes it clear why the message was dropped.

Test Plan:
Notable:

  - `exclude` present in properties
  - Exclusion reason under RECIPIENTS header

{P1229}

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5185

Differential Revision: https://secure.phabricator.com/D10234
2014-08-12 12:28:07 -07:00
..
PhabricatorMailManagementListInboundWorkflow.php Convert more scripts to use PhutilConsoleTable. 2014-06-19 02:36:58 +10:00
PhabricatorMailManagementListOutboundWorkflow.php Convert more scripts to use PhutilConsoleTable. 2014-06-19 02:36:58 +10:00
PhabricatorMailManagementReceiveTestWorkflow.php Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00
PhabricatorMailManagementResendWorkflow.php Allow worker tasks to have priorities 2014-07-12 03:02:06 +10:00
PhabricatorMailManagementSendTestWorkflow.php Persist excluded recipients when saving mail 2014-08-12 12:28:07 -07:00
PhabricatorMailManagementShowInboundWorkflow.php Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00
PhabricatorMailManagementShowOutboundWorkflow.php Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00
PhabricatorMailManagementWorkflow.php Extend all "ManagementWorkflow" classes from a base class 2013-12-27 13:15:40 -08:00