1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 23:32:40 +01:00
phorge-phorge/src/applications/maniphest
epriestley c125ab7a42 Remove "metamta.*.subject-prefix" options
Summary:
In ~2012, the first of these options was added because someone who hates dogs and works at Asana also hated `[Differential]` in the subject line. The use case there was actually //removing// the text, not changing it, but I made the prefix editable since it seemed like slightly less of a one-off.

These options are among the dumbest and most useless config options we have and very rarely used, see T11760. A very small number of instances have configured one of these options.

Newer applications stopped providing these options and no one has complained.

You can get the same effect with `translation.override`. Although I'm not sure we'll keep that around forever, it's a reasonable replacement today. I'll call out an example in the changelog to help installs that want to preserve this option.

If we did want to provide this, it should just be in {nav Applications > Settings} for each application, but I think it's wildly-low-value and "hack via translations" or "local patch" are entirely reasonable if you really want to change these strings.

Test Plan: Grepped for `subject-prefix`.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19993
2019-01-17 19:18:50 -08:00
..
__tests__ Use keywords instead of ints to update task priority in ManiphestEditEngine 2017-06-14 14:43:03 -07:00
application Allow the "Create Subtask" workflow to prompt for a subtype selection, and prepare for customizable options 2018-12-10 14:44:26 -08:00
bulk Remove the Maniphest-specific bulk job type 2018-01-19 12:44:16 -08:00
capability Remove deprecated Maniphest "Can Edit <Specific Property>" capabilities 2018-08-16 10:51:06 -07:00
command Use keywords instead of ints to update task priority in ManiphestEditEngine 2017-06-14 14:43:03 -07:00
conduit Freeze "maniphest.gettasktransactions" and make status/priority transactions more consistent 2017-11-22 11:13:53 -08:00
config Remove "metamta.*.subject-prefix" options 2019-01-17 19:18:50 -08:00
constants Allow objects to be put in an "MFA required for all interactions" mode, and support "MFA required" statuses in Maniphest 2018-12-28 00:10:54 -08:00
controller Correct a zero-based month tooltip on burnup charts 2019-01-15 18:09:18 -08:00
edge Allow duplicates and merged-in tasks to be queried with edge.search 2017-10-13 13:12:50 -07:00
editor Remove "metamta.*.subject-prefix" options 2019-01-17 19:18:50 -08:00
engine Allow objects to be put in an "MFA required for all interactions" mode, and support "MFA required" statuses in Maniphest 2018-12-28 00:10:54 -08:00
engineextension Add more mail stamps: tasks, subscribers, projects, spaces 2018-02-06 04:05:46 -08:00
field Fix errors found by PHPStan 2017-02-17 10:10:15 +00:00
herald Add "you can only enter one value" UI limits to Herald "set status" and "set priority" actions 2018-01-26 13:22:26 -08:00
httpparametertype Make "Create Subtask" work properly in EditEngine 2015-12-08 14:29:58 -08:00
lipsum Use keywords instead of ints to update task priority in ManiphestEditEngine 2017-06-14 14:43:03 -07:00
mail Allow multiple mail receivers to react to an individual email 2019-01-16 12:28:02 -08:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
policyrule Allow PolicyRules to serve as "Object Policies" 2015-06-13 15:44:38 -07:00
query Fix another qsprintf() straggler in "Has Open Subtasks" 2018-12-13 05:17:02 -08:00
relationship Reorder "Merge" transaction to make "Close as Duplicate" produce a "[Merged]" email subject 2019-01-16 13:27:10 -08:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
search Reduce the amount of boilerplate that implementing FerretInterface requires 2017-09-07 13:23:31 -07:00
storage Allow objects to be put in an "MFA required for all interactions" mode, and support "MFA required" statuses in Maniphest 2018-12-28 00:10:54 -08:00
typeahead Replace the informal "array" subtype map with a more formal "SubtypeMap" object 2018-12-09 16:37:35 -08:00
view Replace the informal "array" subtype map with a more formal "SubtypeMap" object 2018-12-09 16:37:35 -08:00
xaction Enrich "priority" transactions in Maniphest for "transaction.search" 2018-08-24 10:05:05 -07:00