1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 19:32:40 +01:00
phorge-phorge/src/applications/repository/management
epriestley 553c335fbd Ignore unreachable commits when testing if a repository has imported
Summary:
Fixes T11309. When checking if a repository was fully imported, we incorrectly allow unreachable, un-imported commits to prevent the repository from moving to "Imported".

This can happen if you delete branches from a repository while it is importing.

Instead, ignore unreachable commits when checking for remaining imports, and when reporting status via `bin/repository importing`.

Test Plan:
  - Stopped daemons.
  - Created a new repository and activated it.
  - Ran `bin/repository update Rxx`.
  - Deleted a branch in the repository.
  - Ran `bin/repository update Rxx`.
  - Ran daemons to flush queue.

Now:

  - Ran `bin/repository importing`. Old behavior: showed unreachable commits as importing. New behavior: does not show unreachable commits.
  - Ran `bin/repository update`. Old behavior: failed to move repository to "imported" status. New behavior: correctly moves repository to "imported" status.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11309

Differential Revision: https://secure.phabricator.com/D16269
2016-07-11 09:23:08 -07:00
..
PhabricatorRepositoryManagementCacheWorkflow.php phtize all the things 2015-05-22 21:16:39 +10:00
PhabricatorRepositoryManagementClusterizeWorkflow.php Add bin/repository clusterize and document setup and migration for clusters 2016-04-26 10:07:17 -07:00
PhabricatorRepositoryManagementDiscoverWorkflow.php Provide a more consistent, mostly relaxed severity for updating non-cluster repositories on cluster devices 2016-05-12 15:51:14 -07:00
PhabricatorRepositoryManagementImportingWorkflow.php Ignore unreachable commits when testing if a repository has imported 2016-07-11 09:23:08 -07:00
PhabricatorRepositoryManagementListPathsWorkflow.php Add repository list-paths and repository move-paths 2015-07-16 14:11:33 -07:00
PhabricatorRepositoryManagementListWorkflow.php Remove calls to getCallsign() in bin/repository scripts 2016-01-02 04:23:26 -08:00
PhabricatorRepositoryManagementLookupUsersWorkflow.php Synchronize working copies before doing a "bypassCache" commit read 2016-04-22 08:11:43 -07:00
PhabricatorRepositoryManagementMarkImportedWorkflow.php Remove calls to getCallsign() in bin/repository scripts 2016-01-02 04:23:26 -08:00
PhabricatorRepositoryManagementMarkReachableWorkflow.php Add "bin/repository mark-reachable" for fixing commit reachability flags 2016-06-16 11:21:17 -07:00
PhabricatorRepositoryManagementMirrorWorkflow.php Provide a more consistent, mostly relaxed severity for updating non-cluster repositories on cluster devices 2016-05-12 15:51:14 -07:00
PhabricatorRepositoryManagementMovePathsWorkflow.php Guarantee repositories have unique local paths 2016-05-04 16:09:52 -07:00
PhabricatorRepositoryManagementParentsWorkflow.php Various translation improvements 2015-11-03 07:02:46 +11:00
PhabricatorRepositoryManagementPullWorkflow.php Provide a more consistent, mostly relaxed severity for updating non-cluster repositories on cluster devices 2016-05-12 15:51:14 -07:00
PhabricatorRepositoryManagementRefsWorkflow.php Provide a more consistent, mostly relaxed severity for updating non-cluster repositories on cluster devices 2016-05-12 15:51:14 -07:00
PhabricatorRepositoryManagementReparseWorkflow.php Remove calls to getCallsign() in bin/repository scripts 2016-01-02 04:23:26 -08:00
PhabricatorRepositoryManagementThawWorkflow.php Implement bin/repository thaw for unfreezing cluster repositories 2016-04-20 10:45:58 -07:00
PhabricatorRepositoryManagementUpdateWorkflow.php Ignore unreachable commits when testing if a repository has imported 2016-07-11 09:23:08 -07:00
PhabricatorRepositoryManagementWorkflow.php Provide a more consistent, mostly relaxed severity for updating non-cluster repositories on cluster devices 2016-05-12 15:51:14 -07:00