revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 17:22:42 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 5839a54b60 Raise a tailored error when calling "transaction.search" with empty "phids" constraint 
Summary:
Ref T13164. See PHI725. For real "*.search" methods, parameters get validated and you get an error if you use an empty list as a constraint.

Since "transaction.search" isn't really a normal "*.search" method, it doesn't benefit from this. Just do the check manually for now.

Test Plan: Made `transaction.search` calls with no constraints (got results); a valid costraint (got fewer results); and an invalid empty constraint (got an exception).

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13164

Differential Revision: https://secure.phabricator.com/D19562
2018-08-03 14:29:36 -07:00
..
almanac Add unique constraint to AlmanacInterfaces 2018-04-19 19:16:50 -07:00
aphlict minor: fix translation error in exception 2018-06-04 17:46:13 +00:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Support an "Ancestors Of: ..." constraint in commit queries 2018-05-08 15:51:42 -07:00
auth Manage object mailKeys automatically in Mail instead of storing them on objects 2018-04-25 06:46:58 -07:00
badges Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
base Revert the alternate menu names for applications 2018-04-08 10:20:24 -07:00
cache Capitalize "OPcache" more consistently 2018-07-26 12:15:57 -07:00
calendar Explicitly add rel="noreferrer" to all external links 2018-02-17 17:46:11 -08:00
celerity Emit a "Content-Security-Policy" HTTP header 2018-02-27 10:17:30 -08:00
chatlog Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
conduit Make the Conduit auth error for an unrecognized public key a little more useful 2018-07-20 09:43:54 -07:00
config Capitalize "OPcache" more consistently 2018-07-26 12:15:57 -07:00
conpherence Read lock all transaction edits 2018-02-10 20:07:46 -08:00
console Fix some minor errors (DarkConsole warning, unstable Ferret sort) 2018-03-18 15:12:25 -07:00
countdown Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
daemon Fix typo in "button" 2018-06-08 15:09:07 -07:00
dashboard Make the dashboard panel datasource work properly with hundreds of panels 2018-06-28 08:54:29 -07:00
differential Add a "Changes Since Last Action" view to Differential revisions 2018-07-27 12:27:33 -07:00
diffusion Deprecate Conduit method "diffusion.getrecentcommitsbypath" 2018-08-03 09:48:58 -07:00
diviner Fix a constant typo in Diviner ("DECLARATAION" -> "TION") 2017-03-04 09:54:10 -08:00
doorkeeper Allow Doorkeeper references to have multiple display variations (full, short, etc.) 2018-03-13 11:29:52 -07:00
draft/storage When purging drafts after a transaction edit, purge all drafts 2018-02-11 06:01:09 -08:00
drydock Fix usage of fprintf() in bin/drydock command 2018-03-28 16:19:55 -07:00
fact Fix some of the most obvious bugs in fact generation from Maniphest tasks 2018-02-19 12:07:28 -08:00
favorites Add some style to label in Favorites Menu 2017-02-01 07:20:31 -08:00
feed Add a rough "bin/repository unpublish" workflow to attempt to cleanup improperly published repositories 2018-03-30 08:46:11 -07:00
files Make the "Is this JSON?" DocumentEngine heuristic a little tighter 2018-07-27 12:27:02 -07:00
flag Remove counts from home navigation 2017-01-21 13:55:40 -08:00
fund Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
guides Make "simple" a "button type", not a "color" 2017-05-30 17:59:37 -07:00
harbormaster Count lines in build log slices more cheaply 2018-07-30 08:25:17 -07:00
help Redesign header menus and search 2017-01-17 12:13:06 -08:00
herald Support querying Herald rules by monogram in typeahead datsources 2018-08-01 17:52:27 -07:00
home Update menu item names for Applications -> Favorites 2017-09-05 19:05:03 -07:00
legalpad Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
lipsum Add "--force" and "--quickly" flags to bin/lipsum 2017-02-27 09:09:41 -08:00
macro Make the meme cache case-sensitive 2018-07-26 12:15:32 -07:00
maniphest Fix "Any Owner" and "No Owners" searches in Maniphest 2018-05-09 13:24:23 -07:00
meta Add transactions for installing/uninstalling applications 2018-04-11 08:54:55 -07:00
metamta Allow mailers to be explicitly marked as inbound or outbound 2018-07-30 08:25:06 -07:00
multimeter Add a cluster.read-only option 2016-04-09 13:40:47 -07:00
notification Fix the most significant "phantom notification" badness 2018-04-19 17:24:19 -07:00
nuance Explicitly add rel="noreferrer" to all external links 2018-02-17 17:46:11 -08:00
oauthserver Remove client OAuth redirect code which was only partially cleaned up 2018-03-06 20:41:13 -08:00
owners Improve UI and documentation for "Ignore Attributes" in Owners slightly 2018-05-08 14:03:30 -07:00
packages Fixing copy/paste mistake 2017-04-19 15:48:59 -07:00
passphrase Fix spelling 2017-10-09 10:48:04 -07:00
paste Fix Lipsum generators for Differential Revisions and Pastes 2018-07-23 15:05:51 -05:00
people Assign RepositoryIdentity objects to commits 2018-05-31 07:28:23 -07:00
phame Revert the alternate menu names for applications 2018-04-08 10:20:24 -07:00
phid Truncate package names in diff table of contents views 2018-06-07 13:17:01 -07:00
phlux Add edge tables for Phlux 2018-04-19 15:49:08 -07:00
pholio Revert the alternate menu names for applications 2018-04-08 10:20:24 -07:00
phortune Add card expiration information to Phortune cart screen 2018-06-02 18:23:44 -07:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phragment Remove PhabricatorFile::buildFromFileDataOrHash() 2017-04-04 16:18:00 -07:00
phrequent Fix spelling 2017-10-09 10:48:04 -07:00
phriction Add a "Last Edited" property to Wiki pages 2018-08-03 14:29:17 -07:00
phurl Explicitly add rel="noreferrer" to all external links 2018-02-17 17:46:11 -08:00
policy Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults 2018-04-27 16:56:11 -07:00
ponder Make Facts more modern, DRY, and dimensional 2018-02-19 12:05:19 -08:00
project Put "Subprojects" on top of "Milestones" in the Project UI 2018-08-01 13:49:42 -07:00
releeph Mostly modularize the Differential "update" transaction 2018-03-06 09:10:32 -08:00
remarkup/conduit
repository Allow push events to be filtered by which Herald rule blocked the push 2018-08-01 17:38:12 -07:00
search Document the Ferret "=" operator and improve related documentation 2018-07-23 12:44:43 -07:00
settings Make the filetree view width sticky across show/hide and reload 2018-02-22 13:47:41 -08:00
slowvote Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
spaces Add more mail stamps: tasks, subscribers, projects, spaces 2018-02-06 04:05:46 -08:00
subscriptions When loading project membership to evaluate the "Subscribers" policy, use the ominipotent viewer 2018-03-14 12:59:31 -07:00
support/application
system Add a generic PHID-based object redirection controller 2018-06-12 11:54:59 -07:00
tokens Property list view on Diffusion commits should show build status but not Subscriptions, Projects, or Tokens 2017-12-01 18:16:26 +00:00
transactions Raise a tailored error when calling "transaction.search" with empty "phids" constraint 2018-08-03 14:29:36 -07:00
typeahead Stop the debugging view for typeahead datasources from fataling 2018-04-08 06:16:56 -07:00
uiexample Reduce the cost of generating default user profile images 2018-03-01 16:53:17 -08:00
xhprof Allow XHProf profiles to be drag-and-dropped to upload them 2017-02-23 11:16:19 -08:00