1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-11 01:12:41 +01:00
phorge-phorge/src/applications/differential
epriestley 5a11f08ba4 Use bar colors to show revision status in revision lists
Summary:
Ref T3772. The original version of D5451 had a very colorful version of this which felt a bit arbitrary, and we moved away from it after discussion, particularly [[ https://secure.phabricator.com/D5451#comment-8 | here (chad) ]] and [[ https://secure.phabricator.com/D5451#comment-14 | here (me) ]] and [[ https://secure.phabricator.com/D5451#comment-19 | here (chad again) ]].

The core of my objection was that status and priority to the viewer aren't the same: a "needs revision" revision that you authored is high priority (you need to revise it), but a "needs revision" revision that someone else authored is low priority (you're waiting on them to revise it). If we color by status, revisions in both high priority and low priority states will be colored red. We can instead color by viewer priority (blocking others = red, needs attention = orange, waiting on others = blue; or something), but that would be redundant (we already group by it, so you'd get big chunks of stuff with the same color and color would have no utility), confusing (in ungrouped views, the colors would not be self-explanatory) and weirdly inconsistent (different users would see objects having different colors).

I still think all this holds, but I also thought that "viewer priority" was enormously more important than "state", since I use the former frequently and the latter very rarely. From T3772, it sounds like some users use "state" a lot more than I do (i.e., they want to find "accepted" revisions within a "viewer priority" group like "Action Required"). This is a possible approach to that.

I think another issue was the heavy use of the color in the original; this restores a more conservative version of it which doesn't have as much weight. In particular:

  - Revisions in the "Needs Review" state retain the default color, rather than orange.
  - Revisions in the "Closed" state have the disabled effect.

Test Plan: See screenshot.

Reviewers: chad, btrahan

Reviewed By: chad

CC: aran

Maniphest Tasks: T3772

Differential Revision: https://secure.phabricator.com/D6839
2013-08-29 09:16:51 -07:00
..
__tests__ Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
application Partially generalize Remarkup previews and add support to Differential 2013-08-05 10:46:39 -07:00
conduit fix perf regression when using 'owned' query 2013-08-28 13:29:36 -07:00
config Flip strings for 'metamta.differential.unified-comment-context' config 2013-04-26 06:19:07 -07:00
constants Store revision reviewer state as edges 2013-07-10 13:50:21 -07:00
controller Update forms to use PHUIFormBoxView 2013-08-26 15:45:58 -07:00
doorkeeper Don't publish story text for "close" stories to Asana 2013-08-07 13:28:58 -07:00
editor Publish inline comments in Asana notification stories 2013-08-13 10:16:56 -07:00
events Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
exception Delete license headers from files 2012-11-05 11:16:51 -08:00
field Allow using colon in Depends On 2013-08-08 11:43:25 -07:00
lipsum xDiffs and Revisions Generating 2013-05-06 14:11:37 -07:00
mail Move PhabricatorUser to new phid stuff 2013-07-26 14:05:19 -07:00
parser Fix typo in comment 2013-06-28 09:40:00 -07:00
phid Fix "setName()" on Differental revision handles 2013-07-22 14:42:31 -07:00
query Allow disabled users to be typeaheaded in Differential 2013-08-28 15:37:53 -07:00
remarkup Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
render Fix function/method declaration lint in Phabricator. Automatic patches. 2013-02-19 13:47:03 -08:00
search Move PhabricatorUser to new phid stuff 2013-07-26 14:05:19 -07:00
storage Remove getApplicationObjectTypeName from ApplicationTransactions 2013-08-21 12:32:06 -07:00
view Use bar colors to show revision status in revision lists 2013-08-29 09:16:51 -07:00
DifferentialTasksAttacher.php Delete license headers from files 2012-11-05 11:16:51 -08:00