mirror of
https://we.phorge.it/source/phorge.git
synced 2025-02-23 20:19:03 +01:00
8f669ea082
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a general replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. Use `phutil_nonempty_scalar()` instead in `PhabricatorSearchDateField.php` as input could only be integer instead of string. Closes T15297 Test Plan: Applied these four changes (on top of D25144, D25145, D25146) and `/people/` finally rendered in web browser. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15297 Differential Revision: https://we.phorge.it/D25147 |
||
|---|---|---|
| .. | ||
| __tests__ | ||
| AphrontListFilterView.php | ||
| AphrontMoreView.php | ||
| AphrontMultiColumnView.php | ||
| AphrontSideNavFilterView.php | ||
| PhabricatorActionListView.php | ||
| PhabricatorActionView.php | ||
| PhabricatorAnchorView.php | ||
| PhabricatorFileLinkView.php | ||
| PhabricatorSourceCodeView.php | ||
| PHUIApplicationMenuView.php | ||
| PHUICurtainPanelView.php | ||
| PHUICurtainView.php | ||