1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-04 12:42:43 +01:00
phorge-phorge/src/applications/settings/panel
epriestley 5a89da12e2 When users have no password on their account, guide them through the "reset password" flow in the guise of "set password"
Summary:
Depends on D20119. Fixes T9512. When you don't have a password on your account, the "Password" panel in Settings is non-obviously useless: you can't provide an old password, so you can't change your password.

The correct remedy is to "Forgot password?" and go through the password reset flow. However, we don't guide you to this and it isn't really self-evident.

Instead:

  - Guide users to the password reset flow.
  - Make it work when you're already logged in.
  - Skin it as a "set password" flow.

We're still requiring you to prove you own the email associated with your account. This is a pretty weak requirement, but maybe stops attackers who use the computer at the library after you do in some bizarre emergency and forget to log out? It would probably be fine to just let users "set password", this mostly just keeps us from having two different pieces of code responsible for setting passwords.

Test Plan:
  - Set password as a logged-in user.
  - Reset password on the normal flow as a logged-out user.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: revi

Maniphest Tasks: T9512

Differential Revision: https://secure.phabricator.com/D20120
2019-02-12 15:19:46 -08:00
..
PhabricatorActivitySettingsPanel.php Add icons to Settings 2019-01-23 13:41:41 -08:00
PhabricatorConpherencePreferencesSettingsPanel.php Add icons to Settings 2019-01-23 13:41:41 -08:00
PhabricatorContactNumbersSettingsPanel.php Support designating a contact number as "primary" 2019-01-23 14:03:08 -08:00
PhabricatorDateTimeSettingsPanel.php Add icons to Settings 2019-01-23 13:41:41 -08:00
PhabricatorDeveloperPreferencesSettingsPanel.php Add icons to Settings 2019-01-23 13:41:41 -08:00
PhabricatorDiffPreferencesSettingsPanel.php Add icons to Settings 2019-01-23 13:41:41 -08:00
PhabricatorDisplayPreferencesSettingsPanel.php Add icons to Settings 2019-01-23 13:41:41 -08:00
PhabricatorEditEngineSettingsPanel.php Update Settings to use full side-navigation 2017-08-04 10:23:01 -07:00
PhabricatorEmailAddressesSettingsPanel.php Replace "getRequestURI()->setQueryParams(array())" with "getPath()" 2019-02-12 14:43:33 -08:00
PhabricatorEmailDeliverySettingsPanel.php Add icons to Settings 2019-01-23 13:41:41 -08:00
PhabricatorEmailFormatSettingsPanel.php Add icons to Settings 2019-01-23 13:41:41 -08:00
PhabricatorEmailPreferencesSettingsPanel.php Add icons to Settings 2019-01-23 13:41:41 -08:00
PhabricatorExternalAccountsSettingsPanel.php Make external link/refresh use provider IDs, switch external account MFA to one-shot 2019-02-12 15:18:08 -08:00
PhabricatorLanguageSettingsPanel.php Allow users to access some settings at the "Add MFA" account setup roadblock 2019-01-23 13:43:28 -08:00
PhabricatorMultiFactorSettingsPanel.php Allow MFA enrollment guidance to be customized 2019-01-30 06:21:58 -08:00
PhabricatorNotificationsSettingsPanel.php Add icons to Settings 2019-01-23 13:41:41 -08:00
PhabricatorPasswordSettingsPanel.php When users have no password on their account, guide them through the "reset password" flow in the guise of "set password" 2019-02-12 15:19:46 -08:00
PhabricatorSessionsSettingsPanel.php Add icons to Settings 2019-01-23 13:41:41 -08:00
PhabricatorSettingsPanel.php Allow users to access some settings at the "Add MFA" account setup roadblock 2019-01-23 13:43:28 -08:00
PhabricatorSSHKeysSettingsPanel.php Add icons to Settings 2019-01-23 13:41:41 -08:00
PhabricatorTokensSettingsPanel.php Add icons to Settings 2019-01-23 13:41:41 -08:00