1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-02 03:32:42 +01:00
phorge-phorge/src/applications/repository/management
epriestley 5b6d6c4fb3 Use repository identities, not denormalized strings, to identify authors for "Revision closed by commit X" stories
Summary:
Ref T12164. Ref T13276. Currently, the parsing pipeline copies the author and committer names and PHIDs into the transcaction record as metadata. They are then rendered directly from the metadata.

This makes planned changes to the parsing pipeline (to prevent races when multiple commits matching a single revision are pushed simultaneously) more difficult, and generally won't work with repository identities.

Instead, load the commit and use its identities.

Test Plan: Loaded a revision, saw the same story rendering for a "Closed by commit" story.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13276, T12164

Differential Revision: https://secure.phabricator.com/D20418
2019-04-17 12:24:49 -07:00
..
PhabricatorRepositoryManagementCacheWorkflow.php phtize all the things 2015-05-22 21:16:39 +10:00
PhabricatorRepositoryManagementClusterizeWorkflow.php Modularize Repository transactions 2018-11-28 14:29:18 -08:00
PhabricatorRepositoryManagementDiscoverWorkflow.php Provide a more consistent, mostly relaxed severity for updating non-cluster repositories on cluster devices 2016-05-12 15:51:14 -07:00
PhabricatorRepositoryManagementHintWorkflow.php Provide a new "hint" table for weird commits (rewritten, unreadable) 2016-08-24 09:31:46 -07:00
PhabricatorRepositoryManagementImportingWorkflow.php Ignore unreachable commits when testing if a repository has imported 2016-07-11 09:23:08 -07:00
PhabricatorRepositoryManagementListPathsWorkflow.php Add repository list-paths and repository move-paths 2015-07-16 14:11:33 -07:00
PhabricatorRepositoryManagementListWorkflow.php Remove calls to getCallsign() in bin/repository scripts 2016-01-02 04:23:26 -08:00
PhabricatorRepositoryManagementLookupUsersWorkflow.php Synchronize working copies before doing a "bypassCache" commit read 2016-04-22 08:11:43 -07:00
PhabricatorRepositoryManagementMarkImportedWorkflow.php Remove calls to getCallsign() in bin/repository scripts 2016-01-02 04:23:26 -08:00
PhabricatorRepositoryManagementMarkReachableWorkflow.php Add "bin/repository mark-reachable" for fixing commit reachability flags 2016-06-16 11:21:17 -07:00
PhabricatorRepositoryManagementMirrorWorkflow.php Provide a more consistent, mostly relaxed severity for updating non-cluster repositories on cluster devices 2016-05-12 15:51:14 -07:00
PhabricatorRepositoryManagementMovePathsWorkflow.php Add a "--force" flag to "bin/repository move-paths" 2016-08-20 14:10:47 -07:00
PhabricatorRepositoryManagementParentsWorkflow.php Update PhabricatorLiskDAO::chunkSQL() for new %Q semantics 2018-11-13 08:59:18 -08:00
PhabricatorRepositoryManagementPullWorkflow.php Provide a more consistent, mostly relaxed severity for updating non-cluster repositories on cluster devices 2016-05-12 15:51:14 -07:00
PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.php Make re-running rebuild-identities a bit faster and add a little progress information 2018-06-12 13:18:54 -07:00
PhabricatorRepositoryManagementRefsWorkflow.php Provide a more consistent, mostly relaxed severity for updating non-cluster repositories on cluster devices 2016-05-12 15:51:14 -07:00
PhabricatorRepositoryManagementReparseWorkflow.php Add workflow to create repository identities 2018-05-31 07:29:57 -07:00
PhabricatorRepositoryManagementThawWorkflow.php Give "Autoclose Only" repository detail proper getters/setters 2018-12-10 10:22:06 -08:00
PhabricatorRepositoryManagementUnpublishWorkflow.php Use repository identities, not denormalized strings, to identify authors for "Revision closed by commit X" stories 2019-04-17 12:24:49 -07:00
PhabricatorRepositoryManagementUpdateWorkflow.php Ignore unreachable commits when testing if a repository has imported 2016-07-11 09:23:08 -07:00
PhabricatorRepositoryManagementWorkflow.php Make repository daemons periodically check for out-of-sync repositories 2019-01-31 22:12:39 -08:00