1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-14 10:52:41 +01:00
phorge-phorge/src/applications/differential
epriestley 7c2f6f8361 Simplify selection of inline comments from RevisionView
Summary: Ref T2222. Currently, we load inline comments by `commentID` here, but we always pass every commentID associated with the revision. Instead, just load non-draft comments by revision ID. This simplifies querying a little bit and is likely faster anyway (draft comments are currently loaded separately).

Test Plan: Looked at some revisions and verified inlines showed up correctly and in the right places.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D6270
2013-06-24 11:01:51 -07:00
..
__tests__ Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
application Put all DifferentialComment loading behind DifferentialCommentQuery 2013-06-21 12:51:18 -07:00
conduit Abstract access to DifferentialInlineComment behind a Query 2013-06-21 12:54:56 -07:00
config Flip strings for 'metamta.differential.unified-comment-context' config 2013-04-26 06:19:07 -07:00
constants PHT's for Differential. 2013-01-24 10:46:47 -08:00
controller Simplify selection of inline comments from RevisionView 2013-06-24 11:01:51 -07:00
data Delete license headers from files 2012-11-05 11:16:51 -08:00
editor Abstract access to DifferentialInlineComment behind a Query 2013-06-21 12:54:56 -07:00
events PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00
exception Delete license headers from files 2012-11-05 11:16:51 -08:00
field Fix foreach key named same as arr 2013-06-23 16:03:11 -07:00
lipsum xDiffs and Revisions Generating 2013-05-06 14:11:37 -07:00
mail Remove the last hardcoding from PhabricatorMetaMTAReceivedMail 2013-05-17 10:00:49 -07:00
parser Fix some Phabricator lint warnings 2013-06-04 15:28:24 -07:00
query Simplify selection of inline comments from RevisionView 2013-06-24 11:01:51 -07:00
remarkup Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
render Fix function/method declaration lint in Phabricator. Automatic patches. 2013-02-19 13:47:03 -08:00
search Abstract access to DifferentialInlineComment behind a Query 2013-06-21 12:54:56 -07:00
storage Undo D6266 (DifferentialComment PHID migration) 2013-06-24 11:00:35 -07:00
view Conpherence - kill the image-based header UI 2013-05-22 16:05:47 -07:00
DifferentialTasksAttacher.php Delete license headers from files 2012-11-05 11:16:51 -08:00