revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-22 18:28:47 +02:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/conpherence/controller
History
epriestley 5f95f2b6d5 Fix variable issue on Conpherence draft saving pathway 
Summary:
When we save a Conpherence draft, the draft part works fine but `$xactions` never gets defined, so this gets hit a little later on:

  [24-Feb-2014 11:46:10] WARNING: [pool www] child 82805 said into stderr: "NOTICE: PHP message: [2014-02-24 11:46:10] EXCEPTION: (RuntimeException) Undefined variable: xactions at [/INSECURE/devtools/libphutil/src/error/PhutilErrorHandler.php:211]"
  [24-Feb-2014 11:46:10] WARNING: [pool www] child 82805 said into stderr: "NOTICE: PHP message:   #0 PhutilErrorHandler::handleError(8, Undefined variable: xactions, /INSECURE/devtools/phabricator/src/applications/conpherence/controller/ConpherenceUpdateController.php, 122, Array of size 13 starting with: { request => Object AphrontRequest }) called at [/INSECURE/devtools/phabricator/src/applications/conpherence/controller/ConpherenceUpdateController.php:122]"
  [24-Feb-2014 11:46:10] WARNING: [pool www] child 82805 said into stderr: "NOTICE: PHP message:   #1 ConpherenceUpdateController::processRequest() called at [/INSECURE/devtools/phabricator/webroot/index.php:87]"

Instead, define `$xactions`.

Test Plan:
  - Type into Conpherence while tailing the error log.
  - After patch, clean error log.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D8323
2014-02-24 11:56:04 -08:00
..
ConpherenceController.php Rename "status" to "event" in most URIs / classes / etc 2014-02-06 10:10:07 -08:00
ConpherenceListController.php Conpherence - make the JS layer a bit better 2013-05-29 12:46:06 -07:00
ConpherenceNewController.php Always pass handles to tokenizers, not <phid -> name> maps 2013-10-07 12:51:24 -07:00
ConpherenceNotificationPanelController.php Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
ConpherenceUpdateController.php Fix variable issue on Conpherence draft saving pathway 2014-02-24 11:56:04 -08:00
ConpherenceViewController.php Conpherence - add draft support 2014-02-17 15:57:13 -08:00
ConpherenceWidgetController.php Conpherence - implement epoch creation slightly differently 2013-06-03 15:40:00 -07:00