1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-11 09:22:40 +01:00
phorge-phorge/src/applications/differential
Nick Harper 6039ca6fb5 Create option for differential custom fields to display warning on accept
Summary:
This adds support to differential fields to display warnings before a revision
gets accepted. Since lint and unit are differential fields, the code for their
warnings was moved into their respective field specification classes, so there
is only one code path for warnings (lint, unit, or custom).

Test Plan:
Select 'Accept' on a revision with lint/unit warnings and see messages appear
like they used to. Change it back to 'Comment' and they go away. Repeat with
a revision without lint/unit warnings and see no warnings appear. Checked
darkconsole to see no errors due to this.

Reviewers: jungejason, epriestley, vrana

Reviewed By: epriestley

CC: aran, Koolvin

Differential Revision: https://secure.phabricator.com/D2363
2012-05-02 14:30:21 -07:00
..
constants Use "closed", not "committed", in Differential 2012-04-23 17:40:57 -07:00
controller Create option for differential custom fields to display warning on accept 2012-05-02 14:30:21 -07:00
data/revisionlist Add "final" to more classes 2012-03-13 11:18:11 -07:00
editor Use "closed", not "committed", in Differential 2012-04-23 17:40:57 -07:00
exception Improve behavior when user submits a no-op action in Differential 2012-01-15 03:44:09 -08:00
field Create option for differential custom fields to display warning on accept 2012-05-02 14:30:21 -07:00
mail Use "closed", not "committed", in Differential 2012-04-23 17:40:57 -07:00
parser/changeset Inform about moved code and prefer it over copied code 2012-04-30 11:01:15 -07:00
query/revision Use "closed", not "committed", in Differential 2012-04-23 17:40:57 -07:00
replyhandler Unfinal "DifferentialReplyHandler" 2012-03-15 14:16:32 -07:00
storage Show verb of closed diff based on backing vcs, not local vcs 2012-05-01 11:30:02 -07:00
tasks Enable updating task->revision assoc 2011-04-26 19:14:47 -07:00
view Create option for differential custom fields to display warning on accept 2012-05-02 14:30:21 -07:00