1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/repository
epriestley 618da2265d Remove all the multi-pass autoclose-branch separate-cache / seenOnBranches junk
Summary:
Ref T4327. Simplify the git discovery process so I can move it to the DiscoveryEngine, so I can make change parsing testable.

In particular:

  - As an optimization, we process closeable branches ("master") first, then process uncloseable branches ("epriestley-devel"). This means that in the common case we can insert a commit as closeable immediately when it is discovered, the first pass through the pipeline will get it right, and the "ref update" step will never need to do any meaningful work.
  - Commits which do not initially appear on a closeable branch, but later move to one (via merges or ref moves) will now be caught in the ref update step, have the closeable flag set, and have a message step re-queued.
  - We no longer need to do a separate discovery step on closable branches.
  - We no longer need to keep track of `seenOnBranches`.

Test Plan: Ran discovery on repositories after pushing commits, got reasonable results.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4327

Differential Revision: https://secure.phabricator.com/D7985
2014-01-17 11:48:53 -08:00
..
application Ship "Repositories" create button to new Diffusion workflow 2013-10-29 15:32:39 -07:00
conduit Migrate repositories to use Passphrase for credential management 2013-11-22 15:23:33 -08:00
constants Build an early multi-step repository create form 2013-07-14 07:37:17 -07:00
controller Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
daemon Remove all the multi-pass autoclose-branch separate-cache / seenOnBranches junk 2014-01-17 11:48:53 -08:00
data Move repository URI normalization out of PullLocalDaemon 2014-01-17 11:48:52 -08:00
editor Allow repositories to be associated with projects 2014-01-03 12:24:09 -08:00
engine Provide an alternate, more general "closeable" flag for commits 2014-01-17 11:48:53 -08:00
management Introduce ref cursors for repository parsing 2014-01-17 11:48:53 -08:00
phid Remove many redundant implementations of canLoadNamedObject() 2013-12-18 12:00:01 -08:00
query Introduce ref cursors for repository parsing 2014-01-17 11:48:53 -08:00
response Accept and route VCS HTTP requests 2013-10-29 15:32:40 -07:00
search Make most repository reads policy-aware 2013-09-25 16:54:48 -07:00
storage Remove all the multi-pass autoclose-branch separate-cache / seenOnBranches junk 2014-01-17 11:48:53 -08:00
worker Perform search indexing in the worker queue and respect bin/search index --background 2014-01-14 13:22:56 -08:00
PhabricatorRepositoryConfigOptions.php Raise a setup warning for missing or invalid local repository directory 2013-10-30 13:07:09 -07:00