revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 15:52:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 623aaf488d Consolidate "Subscribers" Herald field value logic 
Summary:
Ref T8455. The Herald code in general isn't nearly as modular as it should be, and the subscriber code particularly has some legacy cruft. This is making it fragile and causing the issue described in T8455.

Currently, each Herald adapter has essentially identical code which it uses to determine which users are subscribed to an object. Instead, share code between object types.

I removed "explicitCCs":

  - The value was always identical to doing the query in the common/standard way.
  - They were only used to print a diagnostic message on transcripts, which I think is no longer relevant.
    - I believe it predates transactions, so when it was added you couldn't figure out the old object state by looking at the transaction history. Now, CC changes are recorded there, so there's no need to restate the CC state on the transcript.
    - Even if we do want to restore this (or something similar), we can do it directly from Herald now.

Test Plan:
  - Created rules that use the "CCs" field in Herald, Pholio, Maniphest and Differential.
  - Updated objects in each application.
  - Observed valid field reads in the tranascript.
  - Grepped for `FIELD_CC`.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8455

Differential Revision: https://secure.phabricator.com/D13177
2015-06-08 10:18:01 -07:00
..
almanac Fix an issue with AlamancDeviceEditor 2015-06-03 18:41:21 -07:00
aphlict Linter fixes 2015-06-02 22:14:01 +10:00
arcanist/conduit Mark "arcanist.projectinfo" as deprecated 2015-05-25 22:52:41 +10:00
audit Fix slop with previous patch, perhaps 2015-06-03 20:11:33 -07:00
auth Add "Mailing List" users 2015-06-03 18:42:33 -07:00
base Send mail to targets in the user's translation 2015-06-03 18:59:33 -07:00
cache Introduce a request cache mechanism 2015-06-04 17:27:31 -07:00
calendar Show informative errors when attempting to set a recurrence end date on a non-recurring event. 2015-06-07 15:57:19 -07:00
celerity Digest resource cachekeys to maximum length 2015-06-01 09:04:22 -07:00
chatlog phtize all the things 2015-05-22 21:16:39 +10:00
conduit Add "Mailing List" users 2015-06-03 18:42:33 -07:00
config Build separate mail for each recipient, honoring recipient access levels 2015-06-03 18:59:31 -07:00
conpherence Remove *TransactionType classes 2015-06-08 11:26:43 +10:00
console Make everything 1000x or 1000000x slower 2015-05-23 05:36:02 -07:00
countdown phtize all the things 2015-05-22 21:16:39 +10:00
daemon Linter fixes 2015-06-02 22:14:01 +10:00
dashboard phtize all the things 2015-05-22 21:16:39 +10:00
differential Consolidate "Subscribers" Herald field value logic 2015-06-08 10:18:01 -07:00
diffusion Add "Mailing List" users 2015-06-03 18:42:33 -07:00
diviner Rename PhabricatorSearchField to PhabricatorSearchFieldDocumentType 2015-06-05 11:01:25 -07:00
doorkeeper Rename some remarkup classes 2015-06-08 11:27:20 +10:00
draft/storage Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
drydock Linter fixes 2015-06-02 22:14:01 +10:00
fact Introduce a request cache mechanism 2015-06-04 17:27:31 -07:00
feed phtize all the things 2015-05-22 21:16:39 +10:00
files Convert Files to SearchFields 2015-06-07 07:32:09 -07:00
flag phtize all the things 2015-05-22 21:16:39 +10:00
fund phtize all the things 2015-05-22 21:16:39 +10:00
harbormaster Linter fixes 2015-06-02 22:14:01 +10:00
help Use __CLASS__ instead of hard-coding class names 2015-05-14 07:21:13 +10:00
herald Consolidate "Subscribers" Herald field value logic 2015-06-08 10:18:01 -07:00
home phtize all the things 2015-05-22 21:16:39 +10:00
legalpad Remove *TransactionType classes 2015-06-08 11:26:43 +10:00
lipsum phtize all the things 2015-05-22 21:16:39 +10:00
macro Remove *TransactionType classes 2015-06-08 11:26:43 +10:00
mailinglists/storage Put PhabricatorMetaMTAMailingList back to keep bin/storage adjust happy for now 2015-06-03 18:51:40 -07:00
maniphest Rename PhabricatorSearchField to PhabricatorSearchFieldDocumentType 2015-06-05 11:01:25 -07:00
meta phtize all the things 2015-05-22 21:16:39 +10:00
metamta Remove *TransactionType classes 2015-06-08 11:26:43 +10:00
multimeter Use PhutilInvalidStateException 2015-05-14 07:53:52 +10:00
notification Add an index to the story notification table 2015-06-08 11:28:49 +10:00
nuance Give Nuance form sources a web UI 2015-06-05 11:01:06 -07:00
oauthserver Linter fixes 2015-06-02 22:14:01 +10:00
owners Build separate mail for each recipient, honoring recipient access levels 2015-06-03 18:59:31 -07:00
passphrase Rename PhabricatorSearchField to PhabricatorSearchFieldDocumentType 2015-06-05 11:01:25 -07:00
paste Fix some method visibilities 2015-06-08 09:52:14 +10:00
people Fix a minor issue with the approval queue 2015-06-06 06:39:02 -07:00
phame Make PhameBlog implement PhabricatorApplicationTransactionInterface 2015-06-03 18:59:42 -07:00
phid Remove mailing lists application 2015-06-03 18:42:36 -07:00
phlux Transactions - make implementing TYPE_XXXX_POLICY transactions optional 2015-05-19 12:58:18 -07:00
pholio Remove *TransactionType classes 2015-06-08 11:26:43 +10:00
phortune Move all ApplicationTransaction publishing to daemons 2015-06-03 18:59:29 -07:00
phpast phtize all the things 2015-05-22 21:16:39 +10:00
phragment phtize all the things 2015-05-22 21:16:39 +10:00
phrequent phtize all the things 2015-05-22 21:16:39 +10:00
phriction Consolidate "Subscribers" Herald field value logic 2015-06-08 10:18:01 -07:00
policy Provide core policy support for Spaces 2015-06-04 17:46:32 -07:00
ponder Rename PhabricatorSearchField to PhabricatorSearchFieldDocumentType 2015-06-05 11:01:25 -07:00
project Rename PhabricatorSearchField to PhabricatorSearchFieldDocumentType 2015-06-05 11:01:25 -07:00
releeph Linter fixes 2015-06-02 22:14:01 +10:00
remarkup/conduit phtize all the things 2015-05-22 21:16:39 +10:00
repository Rename PhabricatorSearchField to PhabricatorSearchFieldDocumentType 2015-06-05 11:01:25 -07:00
search Stop threading handles through the CustomField + ApplicationSearch pipeline 2015-06-07 07:32:46 -07:00
settings Allow administrators to configure "Email Settings" settings for lists 2015-06-03 18:42:41 -07:00
slowvote phtize all the things 2015-05-22 21:16:39 +10:00
spaces Fix some method visibilities 2015-06-08 09:52:14 +10:00
subscriptions phtize all the things 2015-05-22 21:16:39 +10:00
support/application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
system Remove flags and tokens upon object destruction 2015-06-04 07:23:48 +10:00
tokens phtize all the things 2015-05-22 21:16:39 +10:00
transactions Support Spaces transactions 2015-06-05 10:42:49 -07:00
typeahead phtize all the things 2015-05-22 21:16:39 +10:00
uiexample phtize all the things 2015-05-22 21:16:39 +10:00
xhprof phtize all the things 2015-05-22 21:16:39 +10:00