mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-29 02:02:41 +01:00
65c1c758ed
Summary: Fixes T9648. Diffs currently use `return $this->getRevision()->getViewPolicy();` to inherit their revision's view policy. After the introduction of object policies, this is wrong for policies like "Subscribers", because it means "Subscribers to this object, the diff". Since Diffs have no subscribers, this always fails. Instead, use extended policies so that the object policy evaluates in the context of the correct object (the revision). Test Plan: - Create a revision. - Subscribe `alice` to it. - Set view policy to "Subscribers". - View revision as `alice`. - Before patch: nonsense fatal about missing diff because of policy error. - After patch: `alice` can see the revision. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9648 Differential Revision: https://secure.phabricator.com/D17123 |
||
|---|---|---|
| .. | ||
| __tests__ | ||
| DifferentialAffectedPath.php | ||
| DifferentialChangeset.php | ||
| DifferentialCustomFieldNumericIndex.php | ||
| DifferentialCustomFieldStorage.php | ||
| DifferentialCustomFieldStringIndex.php | ||
| DifferentialDAO.php | ||
| DifferentialDiff.php | ||
| DifferentialDiffProperty.php | ||
| DifferentialDiffTransaction.php | ||
| DifferentialDraft.php | ||
| DifferentialHiddenComment.php | ||
| DifferentialHunk.php | ||
| DifferentialInlineComment.php | ||
| DifferentialLegacyHunk.php | ||
| DifferentialModernHunk.php | ||
| DifferentialReviewerProxy.php | ||
| DifferentialRevision.php | ||
| DifferentialSchemaSpec.php | ||
| DifferentialTransaction.php | ||
| DifferentialTransactionComment.php | ||