revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-30 02:32:42 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 671986592b Add a missing "GROUP BY" to MailQuery when querying for multiple recipients 
Summary:
See <https://discourse.phabricator-community.org/t/mail-details-view-broken/4315>. The change in D21400 detects a missing "GROUP BY" in some variations of this query.

Specifically, we may join multiple recipient rows (since mail may have multiple recipients) and then fail to group the results.

Fix this by adding the "GROUP BY". Additionally, remove the special-cased behavior when no authors or recipients are specified -- it's complicated and not entirely correct (e.g., may produce a "no object" instead of a policy error when querying by ID), and likely predates overheating.

Test Plan:
  - Disabled `metamta.one-mail-per-recipient` in Config.
  - Generated a message to 2+ recipients.
  - Viewed the message detail; queried for the message by specifying 2+ recipients.
  - Viewed the unfiltered list of messages, saw the query overheat.

Differential Revision: https://secure.phabricator.com/D21486
2020-10-30 13:02:22 -07:00
..
almanac Remove code which overrides "diffusion.ssh-username" when instanced 2020-05-15 07:45:06 -07:00
aphlict Reduce the verbosity of the "Aphlict" log 2020-04-14 13:24:44 -07:00
arcanist/conduit
audit Add "internal.commit.search" to replace the cache bypass mode of "diffusion.querycommits" 2020-09-15 17:36:38 -07:00
auth Fix an issue where passphrase-protected private keys were stored without discarding passphrases 2020-05-13 08:14:37 -07:00
badges Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
base Give the Phortune external portal an order view 2019-08-26 07:49:17 -07:00
cache Straighten out replication/cache behavior in "bin/storage dump" 2019-08-28 08:25:40 -07:00
calendar Merge a small amount of remaining "libphutil/" code with Phabricator, break libphutil dependency 2020-02-12 15:17:36 -08:00
celerity Give selected inline comments are more obvious selected state 2020-05-14 14:35:55 -07:00
chatlog Replace "getRequestURI()->setQueryParams(array())" with "getPath()" 2019-02-12 14:43:33 -08:00
conduit Update "arc call-conduit" instructions in Conduit API console for required "--" 2020-10-19 12:02:30 -07:00
config Remove ancient "phd.trace" and "phd.verbose" configuration options 2020-07-23 12:31:32 -07:00
conpherence Improve Conpherence behavior for logged out users. 2019-04-02 14:03:08 -07:00
console When a Paste has a useful alternative rendering in Files, provide a hint 2020-05-01 09:09:42 -07:00
countdown Add a test to verify that all routing maps are plausibly valid, and remove some dead routes 2020-02-14 18:06:24 -08:00
daemon Remove ancient "phd.trace" and "phd.verbose" configuration options 2020-07-23 12:31:32 -07:00
dashboard Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView" 2020-02-04 06:52:23 -08:00
differential Set an explicit height when drawing the dependent revision graph 2020-10-16 14:10:36 -07:00
diffusion Fix an issue where known Subversion commits are incorrectly shown as "Discovering..." 2020-09-17 13:55:47 -07:00
diviner Refine handling of "@task" attributes in Diviner 2020-04-06 11:51:33 -07:00
doorkeeper Remove all readers and all nontrivial writers for "accountType" and "accountDomain" on "ExternalAccount" 2020-02-22 17:48:46 -08:00
draft/storage Save drafts for inline comments currently being edited 2020-05-04 13:19:42 -07:00
drydock Add missing indexes to DrydockRepositoryOperation 2020-09-17 12:10:00 -07:00
fact Fix additional "xprintf()"-class static parameter lint errors 2020-09-08 11:45:48 -07:00
favorites Make "Favorites" work more like other customizable menus 2019-04-09 13:59:35 -07:00
feed Support export of feed transactions to CSV/Excel/etc 2019-05-21 12:47:46 -07:00
files Expose the "file attached to object" and "object attached to file" edges via "edge.search" 2020-10-16 13:45:35 -07:00
flag Add a "Remove flag" action to Herald 2019-09-09 13:15:52 -07:00
fund Update a straggling "getAuthorities()" call in Fund 2019-09-04 07:15:20 -07:00
guides Remove legacy "DashboardInstall" table 2019-04-14 10:27:52 -07:00
harbormaster Fix additional "xprintf()"-class static parameter lint errors 2020-09-08 11:45:48 -07:00
help Tokenize external editor links so they can be safely materialized on the client 2020-04-19 09:02:49 -07:00
herald Add a "Comment content" field to Herald 2020-10-16 13:42:56 -07:00
home Make "Favorites" work more like other customizable menus 2019-04-09 13:59:35 -07:00
legalpad Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them 2019-09-12 14:33:28 -07:00
lipsum Add "--force" and "--quickly" flags to bin/lipsum 2017-02-27 09:09:41 -08:00
macro Improve timeline rendering for old macros 2019-04-18 18:25:17 -07:00
maniphest Fix additional "xprintf()"-class static parameter lint errors 2020-09-08 11:45:48 -07:00
meta Fix a straggling callsite to "renderApplicationPolicy()" 2019-09-12 16:26:57 -07:00
metamta Add a missing "GROUP BY" to MailQuery when querying for multiple recipients 2020-10-30 13:02:22 -07:00
multimeter Fix a PhutilURI issue in Multimeter 2019-02-17 17:39:34 -08:00
notification Fix additional "xprintf()"-class static parameter lint errors 2020-09-08 11:45:48 -07:00
nuance Fix additional "xprintf()"-class static parameter lint errors 2020-09-08 11:45:48 -07:00
oauthserver Lightly modernize OAuth server application view pages 2019-07-02 05:15:37 -07:00
owners Remove "PhabricatorAuditListView" 2020-08-12 09:00:02 -07:00
packages Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface 2018-12-20 15:16:19 -08:00
passphrase Fix an issue where passphrase-protected private keys were stored without discarding passphrases 2020-05-13 08:14:37 -07:00
paste When creating a File storage object for a Paste, try to give it the same name as the Paste 2020-05-01 09:10:31 -07:00
people Replace "DiffusionCommitListView" with "DiffusionCommitGraphView" 2020-08-12 08:59:39 -07:00
phame Add a test to verify that all routing maps are plausibly valid, and remove some dead routes 2020-02-14 18:06:24 -08:00
phid Improve handle/status list display on devices in commit graph lists 2020-08-12 09:04:08 -07:00
phlux Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
pholio Make "Quote" work properly in Pholio 2020-08-10 13:40:25 -07:00
phortune In Phortune accounts, prevent self-removal more narrowly 2020-05-26 07:09:42 -07:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phragment Fix additional "xprintf()"-class static parameter lint errors 2020-09-08 11:45:48 -07:00
phrequent Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
phriction When printing timestamps on paper: use an absolute, context-free date format 2020-09-04 16:36:34 -07:00
phurl Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
policy Fix additional "xprintf()"-class static parameter lint errors 2020-09-08 11:45:48 -07:00
ponder Fix a missing pht() in Ponder 2019-04-12 12:18:56 -07:00
project Fix additional "xprintf()"-class static parameter lint errors 2020-09-08 11:45:48 -07:00
releeph Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
remarkup Recognize self-URI links to Diffusion files and give them special rendering behavior 2019-05-21 13:07:37 -07:00
repository Fix an out-of-order issue in the new update-during-publish behavior 2020-09-17 13:40:45 -07:00
search Fix additional "xprintf()"-class static parameter lint errors 2020-09-08 11:45:48 -07:00
settings Add "idea://" to the upstream editor whitelist 2020-05-01 12:56:35 -07:00
slowvote Deprecate ancient "slowvote.info" API method 2019-07-31 11:28:08 -07:00
spaces Remove "Editable By" description fields in Passphrase, Phame, and Spaces 2019-09-12 09:36:50 -07:00
subscriptions When sorting subscriber references for display in the curtain UI, sort without case sensitivity 2020-02-04 15:26:05 -08:00
support/application
system Make "View as Document Type..." only show valid options 2020-05-12 14:25:37 -07:00
tokens Allow tokens to be awarded to MFA-required objects 2018-12-28 00:14:48 -08:00
transactions Expose the "file attached to object" and "object attached to file" edges via "edge.search" 2020-10-16 13:45:35 -07:00
typeahead Make Portals indexable with Ferret 2019-04-10 13:33:54 -07:00
uiexample Reduce the cost of generating default user profile images 2018-03-01 16:53:17 -08:00
xhprof Allow XHProf profiles to be drag-and-dropped to upload them 2017-02-23 11:16:19 -08:00