mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-27 09:12:41 +01:00
6aac9f99d7
Summary: Fixes T7700. This ends up being kind of tricky because - the key for a given request is only correct at the time the dark console is rendered - the dark console itself should contain every request made, as opposed to being drawn from scratch - in the case of a quicksand request, the behavior gets invoked first with the correctly rendered console as part of the `quicksand-redraw` event and then again shortly after as an ajax request would, except this is incorrect relative to when the key should be calculated... So... - assume we can get away with concurrency between the `quicksand-redraw` event and ajax request invocation of the behavior - cache the right data as part of the `quicksand-redraw` event and then use it in the subsequent ajax call - make sure ajax config gets a 'quicksand' flag ...otherwise its somewhat standard make sure this behavior can be init'd a bunch stuff. Test Plan: visited '/', visited '/differential/', visited '/DXXX' - observed correctly populating dark console with all sorts of good data stuff. navigated backwards and observed dark console staying the same as expected. navigated by clicking links and console updated again Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7700 Differential Revision: https://secure.phabricator.com/D12582 |
||
|---|---|---|
| .. | ||
| behavior-active-nav.js | ||
| behavior-audio-source.js | ||
| behavior-autofocus.js | ||
| behavior-choose-control.js | ||
| behavior-crop.js | ||
| behavior-dark-console.js | ||
| behavior-device.js | ||
| behavior-drag-and-drop-textarea.js | ||
| behavior-error-log.js | ||
| behavior-fancy-datepicker.js | ||
| behavior-file-tree.js | ||
| behavior-form.js | ||
| behavior-gesture.js | ||
| behavior-global-drag-and-drop.js | ||
| behavior-high-security-warning.js | ||
| behavior-history-install.js | ||
| behavior-hovercard.js | ||
| behavior-keyboard-pager.js | ||
| behavior-keyboard-shortcuts.js | ||
| behavior-lightbox-attachments.js | ||
| behavior-line-linker.js | ||
| behavior-more.js | ||
| behavior-object-selector.js | ||
| behavior-oncopy.js | ||
| behavior-phabricator-nav.js | ||
| behavior-phabricator-remarkup-assist.js | ||
| behavior-refresh-csrf.js | ||
| behavior-remarkup-preview.js | ||
| behavior-reorder-applications.js | ||
| behavior-reveal-content.js | ||
| behavior-scrollbar.js | ||
| behavior-search-typeahead.js | ||
| behavior-select-on-click.js | ||
| behavior-toggle-class.js | ||
| behavior-tokenizer.js | ||
| behavior-tooltip.js | ||
| behavior-watch-anchor.js | ||
| behavior-workflow.js | ||
| Busy.js | ||
| DragAndDropFileUpload.js | ||
| DraggableList.js | ||
| FileUpload.js | ||
| Hovercard.js | ||
| KeyboardShortcut.js | ||
| KeyboardShortcutManager.js | ||
| MultirowRowManager.js | ||
| Notification.js | ||
| phtize.js | ||
| Prefab.js | ||
| ShapedRequest.js | ||
| TextAreaUtils.js | ||
| Title.js | ||
| ToolTip.js | ||