1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-14 19:02:41 +01:00
phorge-phorge/src/applications/maniphest
Bob Trahan 9838251515 Make PhabricatorActionListView logged-out user savvy
Summary:
Fixes T2691. Now, all PhabricatorActionListViews in the codebase setObjectHref to $request->getRequestURI. This value is passed over to PhabricatorActionItems right before they are rendered. If a PhabricatorActionItem is a workflow and there is no user OR the user is logged out, we used this objectURI to construct a log in URI.

Potentially added some undesirable behavior to aggressively setUser (and later setObjectURI) from within the List on Actions... This should be okay-ish unless there was a vision of actions having different user objects associated with them. I think this is a safe assumption.

Test Plan: played around with a mock all logged out (Ref T2652) and it worked!

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2691

Differential Revision: https://secure.phabricator.com/D6416
2013-07-12 11:39:47 -07:00
..
application Add Subscribe option to maniphest 2013-05-03 15:47:39 -07:00
auxiliaryfield Valdiate custom field keys 2013-06-24 09:28:36 -07:00
conduit Implement option 1 from T3210 2013-05-17 04:13:58 -07:00
config Delete maniphest.enabled and phriction.enabled 2013-04-08 20:47:59 -07:00
constants Implement color variables in CSS. 2013-06-19 20:25:41 -07:00
controller Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
editor Add Subscribe option to maniphest 2013-05-03 15:47:39 -07:00
event Use PHUIIconView for PhabricatorActionView 2013-07-10 12:33:51 -07:00
export Implemented support for different export formats. 2013-04-11 11:27:36 -07:00
extensions Implement Maniphest auxiliary field 'default' key 2013-03-07 17:23:30 -08:00
lipsum Move sender validation into MailReceiver classes 2013-05-17 03:49:29 -07:00
mail Remove the last hardcoding from PhabricatorMetaMTAReceivedMail 2013-05-17 10:00:49 -07:00
remarkup Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
search Require a viewer to load handles 2013-02-28 17:15:09 -08:00
storage Stop writing empty strings to the ownerPHID column 2013-05-23 09:22:18 -07:00
view Implement color variables in CSS. 2013-06-19 20:25:41 -07:00
ManiphestTaskQuery.php Make "arc tasks --unassigned" actually find unassigned tasks 2013-05-27 13:32:46 -07:00