1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 23:32:40 +01:00
phorge-phorge/webroot/rsrc/js/application
Bob Trahan e4b7263bf8 Conpherence - Differentiate audience of Threads/Rooms with icon
Summary:
Fixes T7629 plus an un filed bug that's breaking creating new threads since we need to add participants EVEN EARLIER than we were doing it now that policy is actually enforced.

Back to the main thrust of this, there is one UI corner case - in the main view if you go from 1:1 to 1:1:1 (i.e. add a 3rd recipient, or Nth in a row) the icon only updates on page reload. I figure this will get sorted out at a later refactor as we make the client better / share more code with durable column.

One other small behavioral oddity is in the main view sometime we start loading with no conpherence. in that case, rather than show some incorrect icon, we show no icon (and "no title") and then things change at load. Seems okay-ish.

Finally, @chad - the CSS is a very work-man-like "use the built in stuff you can specify from PHP" so I'm sure it needs some love.

Test Plan: made all sorts of rooms and threads and liked the icons. noted smooth loading action as i switched around

Reviewers: chad, epriestley

Reviewed By: epriestley

Subscribers: Korvin, chad, epriestley

Maniphest Tasks: T7629

Differential Revision: https://secure.phabricator.com/D12163
2015-03-26 12:24:29 -07:00
..
aphlict Conpherence - fix 0 messages in header race condition 2015-03-16 14:28:25 -07:00
auth Add Persona auth provider 2013-10-14 14:34:57 -07:00
config Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
conpherence Conpherence - Differentiate audience of Threads/Rooms with icon 2015-03-26 12:24:29 -07:00
countdown Define JavaScript functions before they are used 2014-12-30 02:53:32 -08:00
dashboard Fix various spelling mistakes 2014-07-13 00:45:33 +10:00
differential Mostly provide CSS for "done" states 2015-03-25 10:57:08 -07:00
diffusion Fix scrolling behavior in Diffusion 2015-01-29 10:20:35 -08:00
doorkeeper Various linter fixes. 2014-02-26 12:44:58 -08:00
files Various linter fixes. 2014-02-26 12:44:58 -08:00
herald Herald - add support for application emails. 2015-01-29 14:15:38 -08:00
maniphest Fix Maniphest Reports scrolling issues 2015-02-24 09:41:37 -08:00
owners Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00
passphrase Rename Passphrase credential control JS 2015-03-02 13:01:00 -08:00
phame Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
pholio Fix next_src being defined as a global variable 2014-12-30 02:56:50 -08:00
phortune Remove support for Balanced payments 2015-03-13 15:47:37 -07:00
policy Mostly modernize the policy control typeahead 2014-07-17 15:56:20 -07:00
ponder Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
projects Workboards - on edit, remove a task if no longer associated with workboard 2015-01-06 13:28:35 -08:00
releeph Make scrolling happen relative to the main content frame 2015-01-25 08:42:40 -08:00
repository Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
search Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
slowvote Replace the primary scrollbar with a fake one to prepare for a persistent chat column 2015-01-23 13:29:15 -08:00
transactions Fix anchor-clicking scroll positions 2015-01-28 08:26:10 -08:00
uiexample Use window.confirm instead of confirm 2014-12-30 02:55:12 -08:00