epriestley 8d048f06ab Fix a Herald issue where testing commits against rules with revision-related conditions would fail ... Summary: Fixes T11610. Clean up some sketchy old code from long ago. If you had rules that use conditions like "Accepted revision exists" and ran them in the test console, we'd never load the "CommitData" and fatal. Instead, load CommitData in `newTestAdapter()` and generally make these pathways a little more modern. Test Plan: - Wrote an "Accepted Revision Exists" rule. - Ran a commit in the test console. - Before patch, got fatal from T11610. - After patch, got clean test result. - Also pushed a commit and reviewed the transcript to make sure the rule ran properly. Reviewers: joshuaspence, chad Reviewed By: chad Maniphest Tasks: T11610 Differential Revision: https://secure.phabricator.com/D16522		2016-09-08 17:16:40 -07:00
..
application	Correct tooltip label for open audit count	2016-06-01 07:12:10 -07:00
conduit	Load audit requests when querying audits	2015-09-25 10:43:17 -07:00
constants	Update Diffusion UI	2016-03-17 12:05:14 -07:00
controller	Fix two issues with callsign-free repositories	2016-02-26 06:13:46 -08:00
editor	Fix a Herald issue where testing commits against rules with revision-related conditions would fail	2016-09-08 17:16:40 -07:00
mail	Move commits to the "COMMIT" mail prefix	2015-09-25 10:43:11 -07:00
management	Remove various additional calls to getCallsign()	2016-01-02 11:04:22 -08:00
query	More NUX states	2015-12-21 13:13:44 -08:00
storage	Modularize content sources	2016-03-26 11:59:45 -07:00
view	[Redesign] Misc batch of UI buggypoos	2015-06-19 13:18:42 +01:00