1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 07:42:40 +01:00
phorge-phorge/src/applications/transactions
epriestley 6ed123e080 Propagate "unexpandable" PHIDs to feed notification recipient expansion
Summary:
See PHI466. Ref T13108. Somewhat recently, new rules were added so that "Resigning" from a revision takes you off the default recipient list, even if you're still a member of a project or package that is still a reviewer or subscriber.

However, these rules don't currently apply to the similar expansion which occurs in notifications. If you resign from a revision you may still get some notifications (just not email) if a package or project you're a member of is a reviewer or subscriber.

(Possibly these should eventually share more code, but just get things working for now.)

Test Plan:
  - Created a revision as A.
  - Added B as a reviewer.
  - Added a package B is an owner for as a reviewer.
  - As B, resigned. (Make sure B is also not an explicit subscriber.)
  - Commented on the revision as A.
    - Before: B is included in the expanded notification recipient list.
    - After: B is no longer included in the expanded notification recipient list.

Maniphest Tasks: T13108

Differential Revision: https://secure.phabricator.com/D19244
2018-03-21 11:55:52 -07:00
..
application Allow EditEngine forms for objects which support subtyping to have a subtype configured 2017-03-02 04:18:06 -08:00
bulk Document how webhooks work 2018-02-09 13:57:19 -08:00
commentaction When accepting revisions, allow users to accept on behalf of a subset of reviewers 2017-03-22 14:25:04 -07:00
conduit Allow "transaction.search" to be constrained by PHIDs 2018-02-09 13:56:16 -08:00
constants When an object which supports subtypes is created, set its subtype to the creating form's subtype 2017-03-02 04:18:23 -08:00
controller Remove duplicate "Change Default Values" action in form editing workflow 2017-03-22 09:50:38 -07:00
data Don't re-mention users for comment edits 2016-06-13 13:57:59 -07:00
draft Show yellow "draft" bubble in Audit 2017-01-16 10:28:59 -08:00
edges Add "Mute/Unmute" for subscribable objects 2018-02-08 11:06:22 -08:00
editengine Don't make an expensive, unused call to test if a viewer can reassign a task 2018-03-14 12:46:27 -07:00
editfield Accept null via conduit.edit to unassign a task 2018-01-31 15:33:52 -08:00
editor Propagate "unexpandable" PHIDs to feed notification recipient expansion 2018-03-21 11:55:52 -07:00
edittype Accept null via conduit.edit to unassign a task 2018-01-31 15:33:52 -08:00
engineextension When a change removes recipients from an object, send them one last email 2018-02-08 06:28:11 -08:00
error Allow users to unset "Editor", tailor short error messages properly on settings forms 2016-06-05 14:03:02 -07:00
exception Raise a warning when mentioning a user in a comment on a draft revision 2018-03-12 17:03:14 -07:00
feed Hide "abraham landed Dxyz irresponsibly" stories from feed 2018-03-06 17:48:03 -08:00
interface Transactions - adding willRenderTimeline to handle tricky cases 2014-12-04 13:58:52 -08:00
phid Allow ApplicationEditor forms to be reconfigured 2015-11-10 10:24:40 -08:00
query Fix transaction queries using withComments() for transactions with no comments 2017-10-02 09:09:53 -07:00
replyhandler Modularize content sources 2016-03-26 11:59:45 -07:00
response Raise a warning when mentioning a user in a comment on a draft revision 2018-03-12 17:03:14 -07:00
storage Hide "abraham landed Dxyz irresponsibly" stories from feed 2018-03-06 17:48:03 -08:00
typeahead Don't allow forms which can't create objects to be added to profile menus 2017-02-16 15:45:11 -08:00
view Prepare TransactionEditor for silent transactions via bulk edit 2018-01-19 13:23:38 -08:00
worker Cache user notification and message counts 2016-06-05 08:52:43 -07:00
xaction Modularize application transactions in Paste, mostly 2016-06-14 06:13:28 -07:00